laravel-mollie icon indicating copy to clipboard operation
laravel-mollie copied to clipboard

Laravel HTTP client

Open Skullbock opened this issue 3 years ago • 2 comments

I've written for my project a MollieLaravelHttpClientAdapter that implements MollieHttpAdapterInterface and was wondering if it would make sense to PR it here, and have the ServiceProvider use this new client adapter to make the API calls.

It's useful to me because i can then make use of the Http::fake functionality that Laravel provides to fake outgoing calls to Mollie in my tests.

Alongside this, i also have a Mollie::fake() implementation nearly ready to avoid having to test Mollie in integration every time, while retaining the core functionalities

Thanks!

Skullbock avatar Sep 27 '22 10:09 Skullbock

Sounds cool, happy to review it!

sandervanhooft avatar Sep 27 '22 10:09 sandervanhooft

PRed!

Skullbock avatar Sep 27 '22 11:09 Skullbock

@sandervanhooft can this be included in a new release?

Treggats avatar Dec 04 '22 13:12 Treggats

🙏 Thank you 😄

Treggats avatar Dec 05 '22 16:12 Treggats