WooCommerce icon indicating copy to clipboard operation
WooCommerce copied to clipboard

Wrap psr/log in namespace

Open johanmolen opened this issue 11 months ago • 6 comments

This issue is similar as #819.

roots/acorn uses psr/log:^3.0 because of illuminate/log. This raises errors because this package uses ^1.1.4.

Can psr/log be prefixed using Mozart?

johanmolen avatar Mar 11 '24 14:03 johanmolen

Also related #883

johanmolen avatar Mar 11 '24 14:03 johanmolen

@mmaymo Is this on your roadmap? We have multiple websites waiting to be upgraded, but this issue is blocking the upgrade.

tombroucke avatar Jun 11 '24 09:06 tombroucke

I just tried to install the Sentry plugin and bumped into this issue as well as it's giving me inheritance errors:

Fatal error: Declaration of Mollie\WooCommerce\Log\WcPsrLoggerAdapter::log($level, $message, array $context = []) must be compatible with Psr\Log\AbstractLogger::log($level, Stringable|string $message, array $context = []): void in /var/www/html/public_html/wp-content/plugins/mollie-payments-for-woocommerce/src/Log/WcPsrLoggerAdapter.php on line 75

michielgerritsen avatar Jun 20 '24 07:06 michielgerritsen

Hi folks, we are aware of this dependency conflict and are working on a proper solution for the resulting error. That said, this has a significant impact on the development pipeline, so we can't commit to a timeframe just yet, but we'll let you know when there are any news.

InpsydeNiklas avatar Jun 20 '24 13:06 InpsydeNiklas

@InpsydeNiklas I've opened a PR aiming to fix this issue, could you have a look when time permits please?

LeanderFS avatar Aug 05 '24 18:08 LeanderFS

We have also been running into this issue for a while now, it would be huge timesaver if this PR could get merged

0pilatos0 avatar Sep 11 '24 07:09 0pilatos0