Mohammad Luthfi Fathur Rahman
Mohammad Luthfi Fathur Rahman
The avatar is also not showing on the iOS https://user-images.githubusercontent.com/25520267/224719291-c92b3799-8335-4b86-b000-15ed783a0e24.mp4
@abdulrahuman5196 Thanks; I'll test it again with the latest commit. I might be missing something before.
@abdulrahuman5196 Could you update the PR to make the `WorkspaceInvitePage` and `WorkspaceInviteMessagePage` can work with `Form.js` under the hood? Also, check if the `welcomeNote` update when locale change is working...
@abdulrahuman5196 I Found this regression when searching for a new user outside the list. The new user avatar is not showing. Step: 1. Open invite new members' workspace 2. Search...
@luacmartins Hey, I need your help here! We try using `Form.js` for the new page `WorkspaceInviteMessagePage` to send the message to the new member. However, in this PR, the input...
Thank you @abdulrahuman5196, for the summary. I don't have any concerns with creating a new issue for the form refactor. @thienlnam @luacmartins I'll let you guys decide it.
@luacmartins @thienlnam Could you confirm 2 points of @abdulrahuman5196 summary [here](https://github.com/Expensify/App/pull/15672#issuecomment-1478355024) so we can move forward with the PR? Thank you!
@abdulrahuman5196 Sorry for the delay! It seems looks good now, I’ll finish the review today!
Here are the regression I found @abdulrahuman5196 1. The last members draft should be clear after submit https://user-images.githubusercontent.com/25520267/229288608-ffbabd6a-e964-47ea-a6ba-ec343f765da4.mov 2. I can submit an invite to the workspace with no selected...
@abdulrahuman5196 That's all for me. Everything else is seems working fine.