Mohammad Luthfi Fathur Rahman comments

Results 145 comments of


                                            Mohammad Luthfi Fathur Rahman

[$250] [mWeb] - Profile- long pressing checkbox label for timezone gets unfocused on its own after few seconds reported by @daraksha-dk

### Proposal **RCA** Pressable / Touchables `onPress` function is called if released before entering the long press state (which control by `delayLongPress `). We could set the long press like...

[$250] [mWeb] - Profile- long pressing checkbox label for timezone gets unfocused on its own after few seconds reported by @daraksha-dk

> However, on mWeb android (both chrome and firefox), the behavior is the same as with @Dima-Kevanishvili's proposal, which is checkbox is toggled and text is "un-pressed" even if the...

[$250] [mWeb] - Profile- long pressing checkbox label for timezone gets unfocused on its own after few seconds reported by @daraksha-dk

I haven't found any solution for that, but I think the cause is the same with this long-press issue on Android web https://github.com/Expensify/App/issues/12324

[$250] [mWeb] - Profile- long pressing checkbox label for timezone gets unfocused on its own after few seconds reported by @daraksha-dk

I’ll try find out about that.

[$250] [mWeb] - Profile- long pressing checkbox label for timezone gets unfocused on its own after few seconds reported by @daraksha-dk

### Updated proposal The problem that occurred on Android Chrome is because the context menu is canceling the long press. The solution for that problem is to add an event...

[$4,000] Pressing down key on delete workspace popup focuses on the cancel button and then pressing enter key still deletes the workspace - reported by @adeel0202

## Proposal **Edit: If `withNavigationFocus` is implemented in `Button` like proposal in [here](https://github.com/Expensify/App/issues/7623#issuecomment-1065522276), we can add `pressOnEnter` to the button cancel instead. For now, the only solution I can think...

[$4,000] Pressing down key on delete workspace popup focuses on the cancel button and then pressing enter key still deletes the workspace - reported by @adeel0202

## Proposal This issue appears because `onPress` function of `Delete` button is called because we pressed the `Enter Key` on `Cancel` button. https://github.com/Expensify/App/blob/c0b318188856d17249ae3d4c62182d31fb2f56bc/src/components/Button.js#L125-L131 Add some checks to make that the...

[$4,000] Pressing down key on delete workspace popup focuses on the cancel button and then pressing enter key still deletes the workspace - reported by @adeel0202

@Santhosh-Sellavel By the way it's better if you give some feedback for the contributor proposal than emoji 😉

[$4,000] Pressing down key on delete workspace popup focuses on the cancel button and then pressing enter key still deletes the workspace - reported by @adeel0202

@Santhosh-Sellavel Okay, I see it now. Thanks!

[$4,000] Pressing down key on delete workspace popup focuses on the cancel button and then pressing enter key still deletes the workspace - reported by @adeel0202

## Proposal 1. Update `Button` component to use `forwardRef` so we can get the ref from `Pressable` component and can compare it later inside `ConfirmContent` component. ```js export default React.forwardRef((props,...