Andri Möll
Andri Möll
I don't have Node.js v12.4 at hand yet to test, but on Travis all except a UCS-2 encoding tests pass (on v12.0.0 everything passes). Would you mind pasting at least...
I briefly skimmed https://github.com/stripe/stripe-node/blob/e542902dd8fbe591fe3c3ce07a7e89d1d60e4cf7/lib/StripeResource.js#L320 and nothing particularly jumped out, so I'll await for your update when you manage to isolate it a little.
Thanks for the research! I bet it's to do with the fact that Mitm.js kind-of forces a fresh connection every time (https://github.com/moll/node-mitm/blob/58e0673df96b1d16f0de4fc5adf234cfaab2bb44/index.js#L59-L63) and Keep-Alive keeping old ones open. Though I...
I can confirm it goes haywire when you pass an `agent` in with `keepAlive` set to true. In fact, there's a combinatorial explosion with every intercepted connection adding one listener...
Ah, indeed, @papandreou. Thanks for that! I re-opened it to remember to take a look once I jump into this. :)
Seems SPDX supports LGPL-like exceptions with the `WITH` syntax. As nudged by https://github.com/moll/node-mitm/issues/80, Mitm.js now contains the SPDX-compatible `WITH GPL-3.0-linking-exception` suffix. Automated license scanning tools shouldn't now get confused about...
Hey, Good idea! Thanks. I'll take a look! ;-)
Hey again! Are you testing your UDP server at all right now? Creating a local server and connecting to that inside tests perhaps?
Not yet, but will. ;-)
Absolutely. I haven't looked too much into it yet though. Do you have any familiarity with Node's UDP internals?