CoNVaDING icon indicating copy to clipboard operation
CoNVaDING copied to clipboard

unused sub targetAudit in code?

Open duartemolha opened this issue 7 years ago • 2 comments

Hi guys... you might have noticed I have forked your software and been cleaning up some of the code to modify it and and a few features I would like to have.

I will offer it to you when I am done to see if you can use some of the changes in your repo... but by going through the code I came accross 2 subs that does not seem to get called anywhere in the code.

targetAudit and auditTtest

the last one is only called from within targetAudit so both these subs are not called on any of the remaining code.

Something wrong here?

duartemolha avatar Oct 10 '17 10:10 duartemolha

First of all thanks for all the work you're doing on the code. Regarding those two subs, I think either renamed these and continued the code elsewhere or we used it for debugging purposes. I need to check this with @ljohansson .

freerkvandijk avatar Oct 11 '17 08:10 freerkvandijk

Hi Duarte,

Thank you indeed for all your efforts. You are correct that the subs are not used. During development we explored different strategies for statistics calculations. These subs were part of a calculation that was not included in the final version, but we forgot to delete them.

ljohansson avatar Oct 11 '17 10:10 ljohansson