moleculer-apollo-server icon indicating copy to clipboard operation
moleculer-apollo-server copied to clipboard

Upgdate to latest Apollo server / subscriptions

Open code4bones opened this issue 2 years ago • 6 comments

  • upgrade to Apollo server v3 ( + switch from subscriptions-transport-ws to graphql-ws )
  • add Custom PubSub creator ( for use custom PubSubEngine )
  • add Update/Reload schema without restarting server/ws
  • Playground ( RenderPageOptions ) options in serverOptions.playgroundOptions
  • add serverOptions.subscriptions.onConnect should return acts lile graphql-ws
  • add serverOptions.subscriptions.context should return user account ( like "authenticate" method )
  • CAUTION: with new graphql-ws subscriptions are not available in build-in playground
  • WARNING: graphql-upload disabled ( new versions is mjs type )
  • Not tested - DataLoader
  • Example in examples/full/

code4bones avatar Oct 20 '22 18:10 code4bones

Hello! Thanks for your contribution. There are a few quick fixes but important ones:

  1. Look at the diff between the example files. There are a lot of changes that don't make sense for this PR.
  2. You cannot change the description and repository in package.json.
  3. A lot of commented code. If it is not needed, remove it.

intech avatar Oct 24 '22 11:10 intech

how soon this can be merged? Apollo server v2 is very outdated, and it needs to be in v3 atleast.

veeramarni avatar Dec 15 '22 09:12 veeramarni

CI is failed

icebob avatar Dec 15 '22 17:12 icebob

Judging by the CI error, dependency packages like graphql-subscriptions and possibly others should be updated so that there is no conflict between new and old packages in peer dependencies.

intech avatar Dec 16 '22 07:12 intech

How is this coming along? Is there anything I can do to help?

abdavid avatar Mar 15 '23 21:03 abdavid

How is this coming along? Is there anything I can do to help?

Fixing broken tests would help a lot image

AndreMaz avatar Jun 19 '23 18:06 AndreMaz