ESMin icon indicating copy to clipboard operation
ESMin copied to clipboard

Add cross-browser support

Open molarmanful opened this issue 9 years ago • 10 comments

I was thinking about using something like Babel, but I can't seem to get it to work.

molarmanful avatar Dec 03 '15 22:12 molarmanful

I've transpiled it in my fork but the problem seems to be is that you're using property names that aren't actually valid in ES5 / other browsers. My best recommendation is to specifically map each property name to it's shorthand or filter them through something like a RegEx. I'll see if I can get something working

vihanb avatar Dec 30 '15 03:12 vihanb

Wow, nice regex. That has to be golfable :) .

So that's why it wasn't right in my test runs on Chrome. Thanks!

molarmanful avatar Dec 30 '15 04:12 molarmanful

Okay, ESMin now runs fine in Webkit Nightly. Chrome still errors though.

molarmanful avatar May 17 '16 00:05 molarmanful

WebKit Nightly has 100% ES6 support, something is wrong very if it wouldn't work... :P

vihanb avatar May 17 '16 00:05 vihanb

Yeah, but Chrome Canary errors, and it has 100% ES6 support.

molarmanful avatar May 17 '16 00:05 molarmanful

... you should seriously not be dynamically generating property <-> character assignments

vihanb avatar May 17 '16 00:05 vihanb

I don't think that's the problem.

molarmanful avatar May 17 '16 00:05 molarmanful

my guess it's unicode prop names.

vihanb avatar May 17 '16 01:05 vihanb

OH MY GOD I GOT CHROME TO WORK. YESSSSSSSSSSSSSSSS...

molarmanful avatar May 17 '16 04:05 molarmanful

IT WORKS!!!

molarmanful avatar May 17 '16 04:05 molarmanful