Moritz Klack comments

Results 538 comments of


                                            Moritz Klack

implemented more broader tracking of handleConnections

I think the return type is OK or should we add another `NodeConnection` type which is the same thing? Two tiny things: 1. the url should be /use-node-connections and could...

implemented more broader tracking of handleConnections

This is great! Thanks @peterkogo . I think the new API is way better than the previous one :)

Add download button and cli command to clone example locally

proposal: ```bash npx create react-flow folder-name --example custom-node ``` or ```bash npx create xyflow folder-name --lib react --example custom-node ```

Add download button and cli command to clone example locally

@omesome now that we have the action bar, this could be a nice addition. wdyt?

Change hook used by updateNodeInternals to guarantee ordering vs batched store updates

Thanks for your PR! You are calling `useEffect` inside the `useCallback` function. Are you sure that you wanted to suggest this?

`updateNodeData` + React 17

As you said, it seems to be an issue with React17 (works fine with 18). We will look into this.

Drag and drop within React Flow nodes doesn't work - items cannot be dragged inside nodes

please re-open if the issue persists.

With `connectOnClick` set, there is no way to leave the "connecting" state without creating a connection

Yep! I agree, this would be a good enhancement.