inquirer-autocomplete-prompt icon indicating copy to clipboard operation
inquirer-autocomplete-prompt copied to clipboard

chore: support typescript

Open moshfeu opened this issue 4 years ago • 5 comments

If I understand the API correctly. Also, I'm not that expert with TypeScript but this is working for me locally. If anyone else who knows typescript can review it, that will be great.

resolve #107

moshfeu avatar Oct 10 '20 20:10 moshfeu

Please someone merge this!

alma3lol avatar Jan 01 '21 23:01 alma3lol

Bumpppppp

prkirby avatar Jan 28 '22 18:01 prkirby

Hi guys, @jayeeson made pretty nice typings in here: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/inquirer-autocomplete-prompt

If there is a will on both sides (@jayeeson and maintainers here) I can spend some time bringing those typings here. Already did a quick proof of concept and seems to work. The typings themselves needs a bit of love to support everything but I'll hold off for now until we have some agreement here.

ipatalas avatar Jan 05 '23 21:01 ipatalas

The typings are probably a little outdated but it's a small package. What's the motivation to bring the types in here, if you want TS support just add the DefinitelyTyped package

jayeeson avatar Jan 06 '23 03:01 jayeeson

Now I'm having second thoughts. All other inquirer plugins (+ the lib itself) have typings in DefinitelyTyped so it doesn't make sense to break this consistency and I definitely don't want to move them all :)

ipatalas avatar Jan 06 '23 15:01 ipatalas