pioneer icon indicating copy to clipboard operation
pioneer copied to clipboard

Published 20 hours ago • verified publisher icon mojotech

Cleanup driver commands after scenario

Open tomhicks-bsf opened this issue 9 years ago • 5 comments

If a step schedules a lot of driver commands, and an early one fails, if the driver is retained (i.e. keep the same driver for all scenarios) it will carry on with those scheduled commands into the next scenario.

By flushing the command queue after each scenario, we ensure that no 'old' commands are run in the wrong steps.

tomhicks-bsf avatar May 11 '15 07:05 tomhicks-bsf

Looks like this is breaking tests in a really odd wait https://travis-ci.org/mojotech/pioneer/jobs/62042409#L412

samccone avatar May 12 '15 13:05 samccone

@samccone that link looks like it goes to a passing test. :confused:

shoe avatar May 12 '15 13:05 shoe

@shoe if you look at that line only 1 integration test was run :grimacing:

So breaking in this case meaning that this code change has the side-effect of canceling all other integration test runs queued up.

samccone avatar May 12 '15 13:05 samccone

@samccone good catch. "Not all that's green is good" I guess.

shoe avatar May 12 '15 14:05 shoe

Maybe we should do it in before scenario rather than after? Haven't looked at that link yet as I'm in a meeting!

Cheers,Tom

On Tue, May 12, 2015 at 3:37 PM, Chris Shoemaker [email protected] wrote:

@samccone good catch. "Not all that's green is good" I guess.

Reply to this email directly or view it on GitHub: https://github.com/mojotech/pioneer/pull/321#issuecomment-101302895

tomhicks-bsf avatar May 12 '15 14:05 tomhicks-bsf