mojo icon indicating copy to clipboard operation
mojo copied to clipboard

Use subtests t/mojo/template.t; issue #1520

Open tschaefer opened this issue 3 years ago • 9 comments

Summary

Convert t/mojo/template.t to using subtests.

Motivation

See issue #1520

tschaefer avatar Feb 11 '22 22:02 tschaefer

Arguably it could be declared once and reused. It doesn't seem to be subtest-specific and isn't modified.

In tests it is more important to keep the scenarios isolated than to reduce duplicated code.

kraih avatar Feb 25 '22 12:02 kraih

Sorry for the confusion. The close was not on purpose.

I just wanted to ask, if I should fit the indentation manually blamed in the perltidy check? The local run of perltidy with the given .perltidyrc doesn't bring the "wanted" result.

tschaefer avatar Feb 25 '22 17:02 tschaefer

I have version v20211029 of perltidy locally, and running it on that file does produce the indentation changes. Might your version be older?

kathackeray avatar Feb 25 '22 18:02 kathackeray

I'm using v20220217 same as in the related check. It's working from the command line not from within vim, seems some setup stuff from my side. Anyways, I'll force-push the commit.

tschaefer avatar Feb 25 '22 19:02 tschaefer

This pull request is now in conflicts. Could you fix it @tschaefer? 🙏

mergify[bot] avatar Aug 20 '22 11:08 mergify[bot]

This pull request is now in conflicts. Could you fix it @tschaefer? 🙏

mergify[bot] avatar Apr 27 '23 20:04 mergify[bot]

This pull request is now in conflicts. Could you fix it @tschaefer? 🙏

mergify[bot] avatar Aug 14 '23 10:08 mergify[bot]

This pull request is now in conflicts. Could you fix it @tschaefer? 🙏

mergify[bot] avatar Sep 11 '23 18:09 mergify[bot]

This pull request is now in conflicts. Could you fix it @tschaefer? 🙏

mergify[bot] avatar Mar 06 '24 19:03 mergify[bot]