versions icon indicating copy to clipboard operation
versions copied to clipboard

#717: Changing the property prefix to mojohaus.versions

Open andrzejj0 opened this issue 3 years ago • 5 comments

andrzejj0 avatar Sep 21 '22 17:09 andrzejj0

I'm not sure if we should brake compatibility for old properties in simply way.

We rename two old properties:

  • maven.version.rules.serverId
  • maven.version.rules

Probably such properties not widely used, but in this case I would prefer one PR for one property to show such change in releases notes.

slawekjaranowski avatar Sep 21 '22 18:09 slawekjaranowski

Yeah, that was my concern as well... And there's no easy way of providing an alias to a property, besides creating a second parameter.

Should we just leave these two parameters as they are and just rename the third one?

andrzejj0 avatar Sep 21 '22 18:09 andrzejj0

I don't expect a big impacts on users - I think that when we show it in release notes will be acceptable - parameter name for configuration are not changed

slawekjaranowski avatar Sep 21 '22 18:09 slawekjaranowski

I've just noticed this:

@Parameter( property = "versions.skip" )

Should we go for the versions. prefix then?

andrzejj0 avatar Sep 22 '22 18:09 andrzejj0

Should we go for the versions. prefix then?

:+1:

pzygielo avatar Sep 27 '22 08:09 pzygielo