versions icon indicating copy to clipboard operation
versions copied to clipboard

add spi mechanism for VersionHelper

Open XenoAmess opened this issue 2 years ago • 6 comments

add spi mechanism for VersionHelper

close https://github.com/mojohaus/versions-maven-plugin/issues/606

XenoAmess avatar Jul 04 '22 21:07 XenoAmess

Thanks for proposition.

I would do more refactor for such feature

  • separate module for api - in order to allow extension to depends only on simple api not on whole plugin implementation
  • update plugin dependency to newer Maven api, eg 3.2.5
  • use JSR-330 to provide plugin components

of course step by step

slawekjaranowski avatar Jul 04 '22 21:07 slawekjaranowski

By the way we should add IT test for such feature and documentation with simple example.

slawekjaranowski avatar Jul 04 '22 21:07 slawekjaranowski

Thanks for proposition.

I would do more refactor for such feature

  • separate module for api - in order to allow extension to depends only on simple api not on whole plugin implementation
  • update plugin dependency to newer Maven api, eg 3.2.5
  • use JSR-330 to provide plugin components

of course step by step

That would be a very large refactor... At least this project would be split to a multi model maven repo. Too large that I'm just afraid you would'n review it.

XenoAmess avatar Jul 04 '22 22:07 XenoAmess

That would be a very large refactor... At least this project would be split to a multi model maven repo. Too large that I'm just afraid you would'n review it.

I know that can be a big refactor. 😄

slawekjaranowski avatar Jul 05 '22 05:07 slawekjaranowski

That would be a very large refactor... At least this project would be split to a multi model maven repo. Too large that I'm just afraid you would'n review it.

I know that can be a big refactor. 😄

big refactor done! please have a look! @slawekjaranowski

XenoAmess avatar Jul 14 '22 21:07 XenoAmess

great - big thanks, can you do refactoring in separate PR? - only split by module without other changes.

slawekjaranowski avatar Jul 15 '22 09:07 slawekjaranowski

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Aug 21 '23 01:08 github-actions[bot]