versions icon indicating copy to clipboard operation
versions copied to clipboard

Fixed #391 - added support for header authorization

Open eroznik opened this issue 4 years ago • 4 comments

Added support for the Maven 3.x repository system, since I didn't want to break the current implementation(backward compatibility for current plugin users) I added a new configuration property to control which version resolution option should be used(useRepositorySystem, default=false).

The changes were tested locally using Maven 3.6.0 on Ubuntu while accessing:

  • Maven Central
  • self hosted Sonatype Nexus
  • self hosted Gitlab (this case is the reason for the pull request/issue)

The observed behavior before the change:

  • an artifact package + metadata was deleted from the local repository
  • executed versions:update-properties, remote requests to the self hosted Gitlab instance failed(404, Gitlab response for unauthorized requests)
  • the parent version wasn't changed

The observed behavior after the change, with useRepositorySystem=true:

  • an artifact package + metadata was deleted from the local repository
  • executed versions:update-properties, remote requests to the self hosted Gitlab went through, artifact metadata fetched successfully
  • the parent version was updated

eroznik avatar Apr 20 '20 16:04 eroznik

@khmarbaise issue summary was updated to added support for header authorization which describes exactly what i wanted to accomplish with this pull request. Beside the conflicts that are current present, is there anything else required from my side to proceed with the pull request?

eroznik avatar Aug 29 '20 10:08 eroznik

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Aug 30 '21 02:08 github-actions[bot]

Could a maintainer please look at this? Should the conflicts get resolved so the PR gets approved? Is there something that needs to be changed? Or do we close it and forget about it?

eroznik avatar Aug 30 '21 14:08 eroznik

We need this fix. @olamy I see that you have recent activity here. Can you help @eroznik with what is needed to get this fix merged?

atokle avatar Oct 26 '21 21:10 atokle

Looks like fixed in: #825

@eroznik thanks for your effort

slawekjaranowski avatar Dec 05 '22 08:12 slawekjaranowski