license-maven-plugin icon indicating copy to clipboard operation
license-maven-plugin copied to clipboard

Question: xml alternative to THIRD-PARTY.properties with additionnal info

Open fmarot opened this issue 8 years ago • 4 comments

1- I have a requirement where I should add additional info to the info provided in the THIRD-PARTY.properties . For example, I have published in my company repo some specific artifacts based on some open source projects but packaged differently (most are native dependencies packaged in a zip). So there is no licence info, no url, nothing. And the GroupId/ArtifactId are specific to my company: generally I have named them "thirdpaty.com.opensourceproject:projectname". So when I generate the THIRD-PARTY file, I miss some info for some artifacts (url, real project name).

My solution would be to have a THIRD-PARTY.xml file with some additionnal data as regard to the (too simple) THIRD-PARTY.properties. What do you think ? Would it be something that would be merged if I ever implemented it correctly ?

Some additionnal unrelated questions:

2- Another "problem" I have is having the THIRD-PARTY.properties reference hardcoded versions. I would not like to have to change the "version" each time I change the versions of the deps in my pom.xml. So I'd like to have something like a wildcard to be compatible with whatever version

Nevertheless, thank you for the work on the plugin !

UPDATE: I have removed my question number '3' as it was invalid. Sorry ;)

fmarot avatar May 24 '16 08:05 fmarot

Hi @fmarot, if you have any existing working solutions, for your both problems, do not fear to threw them here via some PR.

tchemit avatar May 24 '16 10:05 tchemit

Hi ! No I have no solutions developed, but I may be interested in implementing them if you are interested. If you are not, I may dev another in-house solution. I'd like to leverage the existing plugins if you are interested. And even if you are interested and IF I dev something, I understand it may not be merged, depending on many things (quality...). But if the feature I propose are of any interest, I'll be more motivated ;)

fmarot avatar May 24 '16 10:05 fmarot

@fmarot Ok, would be a pleasure to work together in the haus. Can you provide a sample example of your proposal (for question 1). For question 2, could you create a separate issue please, will be some easy to work on it then.

tchemit avatar May 24 '16 13:05 tchemit

What I would like to have would be a merge of THIRD-PARTY.properties and licenses.xml. If the license information is incorrectly configured for an artifact it is needed to setup similar information in two different places with two different file formats for add-third-party and download-licenses goals.

Matze2 avatar May 25 '16 10:05 Matze2