flatten-maven-plugin icon indicating copy to clipboard operation
flatten-maven-plugin copied to clipboard
verified publisher icon mojohaus

Feature/extended interpolate

Open SergeDemoulinGebit opened this issue 2 years ago • 8 comments

new ElementHandling: "extended_interpolate"

  • Take the element from the interpolated POM, but resolve the variables with the properties from the effective POM.
  • Don't resolve the following variables "project.basedir", "project.baseUri", "project.build.directory", "project.build.outputDirectory", "project.build.sourceDirectory", "project.build.scriptSourceDirectory", "project.build.testSourceDirectory", "project.reporting.outputDirectory"
  • Interpolate the parent version

Optimization (only the used models are created)

SergeDemoulinGebit avatar Nov 21 '23 16:11 SergeDemoulinGebit

resolve #383 resolve #382

SergeDemoulinGebit avatar Nov 21 '23 16:11 SergeDemoulinGebit

Please don't change line end and other whitespace

slawekjaranowski avatar Jan 09 '24 08:01 slawekjaranowski

Hi I fix the line ends now. Sorry for the late answer, I did not see the comment. This feature is important for us and very useful.

I want to remove the dependency to guava. Please wait until I do that to make the review.

Best regards, Serge

SergeDemoulinGebit avatar Mar 12 '24 11:03 SergeDemoulinGebit

This would be huge for us because we have a lot of properties in a parent that need to be interpolated in lower POMs.

kjq avatar Mar 24 '24 23:03 kjq

Is there anything we can do to move this forward?

cpfeiffer avatar May 08 '24 08:05 cpfeiffer

I added myself to review, I will try to do it in a few days - @SergeDemoulinGebit thanks for PR

slawekjaranowski avatar May 08 '24 16:05 slawekjaranowski

right. I learnt it afterall

SergeDemoulinGebit avatar May 14 '24 07:05 SergeDemoulinGebit

The requested changes should be handled AFAICS. Anything else what should be done?

cpfeiffer avatar Jun 06 '24 10:06 cpfeiffer

Kind request -- can we move forward with this?

cpfeiffer avatar Sep 11 '24 08:09 cpfeiffer

@SergeDemoulinGebit thanks

slawekjaranowski avatar Sep 13 '24 18:09 slawekjaranowski

Awesome, thank you so much!

cpfeiffer avatar Sep 16 '24 08:09 cpfeiffer

Thank you Slawomir 😄

From: Slawomir Jaranowski @.> Sent: 13 September 2024 20:17 To: mojohaus/flatten-maven-plugin @.> Cc: Serge Démoulin @.>; Mention @.> Subject: Re: [mojohaus/flatten-maven-plugin] Feature/extended interpolate (PR #384)

@SergeDemoulinGebithttps://github.com/SergeDemoulinGebit thanks

— Reply to this email directly, view it on GitHubhttps://github.com/mojohaus/flatten-maven-plugin/pull/384#issuecomment-2349764026, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAILLUDEAHZWTZDFEPVQIM3ZWMT4TAVCNFSM6AAAAAA7U2QO5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZG43DIMBSGY. You are receiving this because you were mentioned.Message ID: @.***>

SergeDemoulinGebit avatar Sep 16 '24 08:09 SergeDemoulinGebit