appassembler icon indicating copy to clipboard operation
appassembler copied to clipboard

useAllProjectDependencies does not include transitive dependencies

Open jansohn opened this issue 9 years ago • 3 comments

I want to use the option useAllProjectDependencies=true to also include dependencies in test scope. If I enable this option the transitive dependencies are not copied to the repo directory.

Example

commons-configuration.commons-configuration:1.10 has two transitive dependencies:

  • commons-lang.commons-lang:2.6
  • commons-logging.commons-logging:1.1.1

These are only copied if I disable useAllProjectDependencies. Is this behavior as designed or a bug?

I'm using appassembler-maven-plugin 1.10 and JDK 1.8.0_71 (32bit).

jansohn avatar Aug 17 '16 09:08 jansohn

I am also experiencing the same thing. I wouldn't imagine it was by design, seems like a bug, but would like to have that confirmed true or not.

NickDiMucci avatar Sep 29 '16 19:09 NickDiMucci

There's a TODO defined at the relevant location (https://github.com/mojohaus/appassembler/blob/d4cf5f278e95af4f46fa83fcbd3136757935d0ce/appassembler-maven-plugin/src/main/java/org/codehaus/mojo/appassembler/AssembleMojo.java#L261) which seems to indicate that they are aware that the current behavior is not optimal...

EDIT: Actually functionality seems to have changed between Maven 2 and Maven 3 for the method getDependencyArtifacts(). In Maven 3 one should use getArtifacts() instead. (http://stackoverflow.com/q/1492000/3375325)

jansohn avatar Sep 30 '16 11:09 jansohn

Hi, any update on this ? I have the same issue. (maven 3.3.9 and appassembler 2.0.0) thanks

ncoquelet avatar Jul 24 '17 09:07 ncoquelet