heroku-buildpack-jemalloc icon indicating copy to clipboard operation
heroku-buildpack-jemalloc copied to clipboard

Upgrade to 4.0.4

Open nateberkopec opened this issue 9 years ago • 10 comments

nateberkopec avatar Jan 15 '16 13:01 nateberkopec

Also, it'd be nice if we could download jemalloc from some more official source.

EDIT: You could probably add it to the git repo here and use something like rawgit.com to download from it.

nateberkopec avatar Jan 18 '16 14:01 nateberkopec

Agreed, though it needs to be built at some point. Adding it to the git repo would make it available at build time (w/o the download), but would also bloat the repo some, slowing things down.

Attaching it to a release might actually do the trick. I'll try creating a release for the current version and adding the binary.

(I don't actually use this buildpack--it was to facilitate some experiments a while back, so if you'd like to potentially adopt it, let me know.)

mojodna avatar Jan 18 '16 17:01 mojodna

Yup, looks like that would work: https://github.com/mojodna/heroku-buildpack-jemalloc/releases/tag/v3.6.0

mojodna avatar Jan 18 '16 17:01 mojodna

@mojodna perhaps could adopt it, let me work a little more with it first. but it works great in production with the new buildpacks features, so I think more people should be looking at this.

nateberkopec avatar Jan 18 '16 18:01 nateberkopec

Sweet, keep me posted!

mojodna avatar Jan 18 '16 18:01 mojodna

Hi, any luck with building this? 4.2.1 is already available.

heaven avatar Jun 23 '16 17:06 heaven

Simply haven't had time - everything you need in the repo is there if you want to give it a shot! Will accept PRs.

nateberkopec avatar Jun 23 '16 17:06 nateberkopec

v5.0.0 just came out today. I'd do a PR for it, but I don't know how the build process works when building for a different environment than my local machine. How has this been done in the past?

brian-kephart avatar Jun 14 '17 04:06 brian-kephart

There's a Makefile in the root that uses Docker to build it against the Heroku image (and extract it so that it can be uploaded to GitHub for referencing by bin/compile).

mojodna avatar Jun 15 '17 18:06 mojodna

https://github.com/mojodna/heroku-buildpack-jemalloc/commit/0938c22 is largely suitable for a PR (without the line I commented on).

mojodna avatar Jun 15 '17 18:06 mojodna