project icon indicating copy to clipboard operation
project copied to clipboard

Settlement GP tests failing after recent changes in release v17.2.5

Open shashi165 opened this issue 1 month ago • 0 comments

Summary: The settlement GP tests are failing after recent changes in the central-settlement PR

Error Message:

2025-11-14T16:15:41.371Z - error: LOG_EVENT_ACTION - {"content":{"error":{"apiErrorCode":{"code":"2001","httpStatusCode":500,"message":"Internal server error","name":"INTERNAL_SERVER_ERROR","type":{"description":"Generic Server Error","httpStatusCode":500,"name":"GENERIC_SERVER_ERROR","regex":"^20[0-9]{2}$"}},"cause":"TypeError: Cannot read properties of null (reading 'ledgerAccountTypeId')\n    at /opt/app/src/models/settlementWindow/facade.js:73:59\n    at Table.query (/opt/app/node_modules/@mojaloop/database-lib/src/table.js:65:12)\n    at Object.getByListOfIds (/opt/app/src/models/settlementWindow/facade.js:67:40)\n    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)\n    at async Object.settlementEventTrigger (/opt/app/src/domain/settlement/index.js:279:26)\n    at async createSettlementEvent (/opt/app/src/api/handlers/settlements.js:107:32)\n    at async exports.Manager.execute (/opt/app/node_modules/@hapi/hapi/lib/toolkit.js:60:28)\n    at async internals.handler (/opt/app/node_modules/@hapi/hapi/lib/handler.js:46:20)\n    at async exports.execute (/opt/app/node_modules/@hapi/hapi/lib/handler.js:31:20)\n    at async Request._lifecycle (/opt/app/node_modules/@hapi/hapi/lib/request.js:370:32)","data":null,"httpStatusCode":500,"isBoom":true,"isServer":true,"message":"Cannot read properties of null (reading 'ledgerAccountTypeId')","name":"FSPIOPError","output":{"headers":{},"payload":{"errorInformation":{"errorCode":"2001","errorDescription":"Internal server error - Cannot read properties of null (reading 'ledgerAccountTypeId')"}},"statusCode":500},"stack":"FSPIOPError: Cannot read properties of null (reading 'ledgerAccountTypeId')\n    at createFSPIOPError (/opt/app/node_modules/@mojaloop/central-services-error-handling/src/factory.js:199:12)\n    at Object.reformatFSPIOPError (/opt/app/node_modules/@mojaloop/central-services-error-handling/src/factory.js:334:12)\n    at createSettlementEvent (/opt/app/src/api/handlers/settlements.js:111:35)\n    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)\n    at async exports.Manager.execute (/opt/app/node_modules/@hapi/hapi/lib/toolkit.js:60:28)\n    at async internals.handler (/opt/app/node_modules/@hapi/hapi/lib/handler.js:46:20)\n    at async exports.execute (/opt/app/node_modules/@hapi/hapi/lib/handler.js:31:20)\n    at async Request._lifecycle (/opt/app/node_modules/@hapi/hapi/lib/request.js:370:32)\n    at async Request._execute (/opt/app/node_modules/@hapi/hapi/lib/request.js:280:9)\nTypeError: Cannot read properties of null (reading 'ledgerAccountTypeId')\n    at /opt/app/src/models/settlementWindow/facade.js:73:59\n    at Table.query (/opt/app/node_modules/@mojaloop/database-lib/src/table.js:65:12)\n    at Object.getByListOfIds (/opt/app/src/models/settlementWindow/facade.js:67:40)\n    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)\n    at async Object.settlementEventTrigger (/opt/app/src/domain/settlement/index.js:279:26)\n    at async createSettlementEvent (/opt/app/src/api/handlers/settlements.js:107:32)\n    at async exports.Manager.execute (/opt/app/node_modules/@hapi/hapi/lib/toolkit.js:60:28)\n    at async internals.handler (/opt/app/node_modules/@hapi/hapi/lib/handler.js:46:20)\n    at async exports.execute (/opt/app/node_modules/@hapi/hapi/lib/handler.js:31:20)\n    at async Request._lifecycle (/opt/app/node_modules/@hapi/hapi/lib/request.js:370:32)","useMessageAsDescription":false}},"id":"80aa7cb5-795e-4bdd-b97e-f59ac7b8f549","metadata":{"event":{"action":"error","createdAt":"2025-11-14T16:15:41.371Z","id":"9d18d977-971f-43b8-9b7e-97791d68153b","state":{"code":"2001","description":"Internal server error - Cannot read properties of null (reading 'ledgerAccountTypeId')","status":"failed"},"type":"log"},"trace":{"flags":"01","sampled":1,"service":"createSettlement","spanId":"ee45f4fbd395b908","startTimestamp":"2025-11-14T16:15:41.362Z","tags":{"source":"testingtoolkitdfsp","tracestate":"mojaloop=eyJzcGFuSWQiOiJlZTQ1ZjRmYmQzOTViOTA4In0=","transactionAction":"post","transactionId":"12","transactionType":"settlement"},"traceId":"aabb805cda76f86f5a35751a131a269b","tracestates":{"mojaloop":{"spanId":"ee45f4fbd395b908"}}}},"type":"application/json"}

Last successful run we get with image: mojaloop/central-settlement:v17.2.4 and testing-toolkit-test-cases:v17.3.0

Need to verify the changes to the settlement service as well as the testing-toolkit-test-cases

Severity: High

Priority: Critical

Expected Behavior

All the GP tests should pass

Steps to Reproduce

  1. deploy the latest v17.2.5 version service
  2. run the GP tests
  3. observe the failures

Specifications

  • Component (if known): central-settlement
  • Version: v17.2.5
  • Platform: mojaloop
  • Subsystem: settlement
  • Type of testing: release candidate testing
  • Bug found/raised by: @shashi165 , @elnyry-sam-k

Notes:

  • Severity when opened: High
  • Priority when opened: Critical

shashi165 avatar Nov 14 '25 17:11 shashi165