project icon indicating copy to clipboard operation
project copied to clipboard

[TTK] - testing-toolkit mock callback responses are not as per the fspiop specs

Open shashi165 opened this issue 10 months ago • 0 comments

Summary: ml-testing-toolkit mock callback response headers and body are not as per the fspiop spec. They contain fields with garbage key/value pairs e.g. mock response to POST /quotes

mock response headers:

{
  "content-type": "application/vnd.interoperability.quotes+json;version=1.0",
  "date": "Thu, 13 Feb 2025 18:29:38 GMT",
  "fspiop-source": "payeefsp",
  "fspiop-destination": "testingtoolkitdfsp",
  "fspiop-http-method": "fugiat anim adipisicing magna commodo",
  "fspiop-signature": "eiusmod",
  "fspiop-uri": "labore in in consectetur",
  "traceparent": "00-aabb35e93e9afdbadc16fbb3c77792d9-6499ecba4e9335ff-01",
  "tracestate": "acmevendor=eyJzcGFuSWQiOiI2NDk5ZWNiYTRlOTMzNWZmIn0=",
  "user-agent": "axios/1.7.9",
  "content-length": "1958",
  "accept-encoding": "gzip, compress, deflate, br",
  "host": "mojaloop-testing-toolkit:4040",
  "connection": "keep-alive"
}

See "fspiop-uri" or "fspiop-http-method" header value above.

mock response body:

{
  "transferAmount": {
    "dolor_e4": 77715370,
    "elit_0_": true,
    "currency": "USD",
    "amount": "100.5"
  },
  "payeeReceiveAmount": {
    "currency": "USD",
    "amount": "100"
  },
  "payeeFspFee": {
    "aliquip_104": -14817306.450870886,
    "estb6": "ad exercitation",
    "voluptate_c": -60723878.179324366,
    "nostrud_9": 97057340,
    "in55": false,
    "Excepteur8da": -41681329.82321304,
    "currency": "USD",
    "amount": "0.2"
  },
  "payeeFspCommission": {
    "officiad": true,
    "pariatur90": "tempor aliqua",
    "non_": true,
    "cupidatat6e": 40031297.4586969,
    "do_a": -72140656,
    "anim_0_": 3976747.5222077966,
    "aliquip8": 67384175.95904002,
    "currency": "USD",
    "amount": "0.3"
  },
  "expiration": "2025-02-14T18:29:41.350Z",
  "geoCode": {
    "id__": "esse cillum",
    "latitude": "4.988878",
    "longitude": "180"
  },
  "ilpPacket": "AYIDgAAAAAAAACdCHWcucGF5ZWVmc3AubXNpc2RuLjI3NzEzODAzOTEyggNWZXlKMGNtRnVjMkZqZEdsdmJrbGtJam9pWkRNeE5qUXdZbVF0TWpBeE15MDBNems0TFdFelpXUXRNV1F6TlRWbE5EZ3dNR1ZrSWl3aWNYVnZkR1ZKWkNJNklqRXlaR1l6T0RoaExUbGxNR0V0TkdGa1lpMWlNbUZsTFdNM01UVTROVEk1T1RKbU9DSXNJbkJoZVdWbElqcDdJbkJoY25SNVNXUkpibVp2SWpwN0luQmhjblI1U1dSVWVYQmxJam9pVFZOSlUwUk9JaXdpY0dGeWRIbEpaR1Z1ZEdsbWFXVnlJam9pTWpjM01UTTRNRE01TVRJaUxDSm1jM0JKWkNJNkluQmhlV1ZsWm5Od0luMTlMQ0p3WVhsbGNpSTZleUp3WVhKMGVVbGtTVzVtYnlJNmV5SndZWEowZVVsa1ZIbHdaU0k2SWsxVFNWTkVUaUlzSW5CaGNuUjVTV1JsYm5ScFptbGxjaUk2SWpRME1USXpORFUyTnpnNUlpd2labk53U1dRaU9pSjBaWE4wYVc1bmRHOXZiR3RwZEdSbWMzQWlmU3dpY0dWeWMyOXVZV3hKYm1adklqcDdJbU52YlhCc1pYaE9ZVzFsSWpwN0ltWnBjbk4wVG1GdFpTSTZJa1pwY25OMGJtRnRaUzFVWlhOMElpd2liR0Z6ZEU1aGJXVWlPaUpNWVhOMGJtRnRaUzFVWlhOMEluMHNJbVJoZEdWUFprSnBjblJvSWpvaU1UazROQzB3TVMwd01TSjlmU3dpWVcxdmRXNTBJanA3SW1SdmJHOXlYMlUwSWpvM056Y3hOVE0zTUN3aVpXeHBkRjh3WHlJNmRISjFaU3dpWTNWeWNtVnVZM2tpT2lKVlUwUWlMQ0poYlc5MWJuUWlPaUl4TURBdU5TSjlMQ0owY21GdWMyRmpkR2x2YmxSNWNHVWlPbnNpYzJObGJtRnlhVzhpT2lKVVVrRk9VMFpGVWlJc0ltbHVhWFJwWVhSdmNpSTZJbEJCV1VWU0lpd2lhVzVwZEdsaGRHOXlWSGx3WlNJNklrTlBUbE5WVFVWU0luMHNJbVY0Y0dseVlYUnBiMjRpT2lJeU1ESTFMVEF5TFRFMFZERTRPakk1T2pReExqTTFNRm9pZlEA",
  "condition": "2_Sxw1KbEW7W4a-lwAP_9ollfohVPwCgKQv6WMh0-BI"
}

e.g.: transferAmount.dolor_e4, transferAmount.elit_0_ etc

Note: This is happening in older versions of TTK also e.g. v16.1.1

Severity: Medium

Priority: Medium

Expected Behavior The TTK should generate headers and body in compliance with the fspiop spec. It should now generate additional fields like above.

Steps to Reproduce

  1. Run TTK locally
  2. Run the p2p_money_transfer - p2p_happy_path tests from the TTK UI.
  3. Check the "Response" tab of the quote request for example.
  4. See the Call back response and headers

Specifications

  • Component (if known): ml-testing-toolkit
  • Version: 18.7.1/ 16.1.1
  • Platform: Mojaloop
  • Subsystem: TTK
  • Type of testing:
  • Bug found/raised by: @shashi165

Notes:

  • Severity when opened: High
  • Priority when opened: High

shashi165 avatar Feb 13 '25 18:02 shashi165