project icon indicating copy to clipboard operation
project copied to clipboard

Quality improvements on beneficiary-registration-portal-frontend

Open PaulGregoryBaker opened this issue 9 months ago • 0 comments

Goal:

As a Community member interested in the G2P usecase that leverages MOSIP to manage personal payment aliases I want to quality software assets so that I can make use for and confidently modify the software

Acceptance Criteria:

  • [ ] Verify that beneficiary-registration-portal-frontend is updated to include
    • [ ] latest dependencies
    • [ ] all unused depencencies are removed
    • [ ] licence error is fixed (details below)
    • [ ] automated tests unit tests are added
    • [ ] API has an Open API definition file
    • [ ] all unused depencencies are removed
    • [ ] Testing coverage meets standards

licence-scanner error: https://app.circleci.com/pipelines/github/mojaloop/beneficiary-management-system-svc/2/workflows/fa306d87-54d4-4761-8ac0-2a3d4fcd47ba/jobs/15

Allowing only the following licenses: AFLv2.1;Apache License, Version 2.0;Apache*;Apache-2.0;Apache 2.0;BlueOak-1.0.0;BSD;BSD*;BSD-2-Clause;BSD-3-Clause;BSD-3-Clause-Clear;CC-BY-3.0;CC-BY-4.0;CC0-1.0;ISC;MIT;MIT*;Public Domain;Python-2.0;UNLICENSED;Unlicense;Unlicensed;WTFPL;(BSD-2-Clause OR MIT OR Apache-2.0);(MIT OR Apache-2.0);(MIT OR CC0-1.0);(Unlicense OR Apache-2.0);WTFPL OR ISC;(WTFPL OR MIT)

Package "[email protected]" is licensed under "MPL-2.0" which is not permitted by the --onlyAllow flag. Exiting.
make: *** [Makefile:49: run] Error 1

What should be done to fix it: Identify which UI package is using [email protected], and try to remove/update it. I think, @James Simbi is able to do it.

Goal:

As a <stakeholder|persona>

I want to

so that

Acceptance Criteria:

  • [ ] TBD

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • [ ] TBD [ @? ]

Done

  • [ ] Acceptance Criteria pass
  • [ ] Designs are up-to date
  • [ ] Unit Tests pass
  • [ ] Integration Tests pass
  • [ ] Code Style & Coverage meets standards
  • [ ] Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • [ ] TBD

Pull Requests:

  • [ ] TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC

PaulGregoryBaker avatar May 23 '24 11:05 PaulGregoryBaker