project icon indicating copy to clipboard operation
project copied to clipboard

"participants-bc" repo to use standard CI/CD steps, checks

Open ei-nghon-phoo opened this issue 10 months ago • 3 comments

Goal:

As an adopter of Mojaloop

I want to ensure that standard CI/CD steps adopted by Mojaloop are followed for mojaloop/participants-bc

so that I can be confident of the quality of the codebase of this repo

Acceptance Criteria:

  • [ ] CI/CD steps listed below are configured for the security-bc repo and pass
    • [ ] Integration tests
    • [ ] Vulnerability checks
    • [ ] Image scans
    • [ ] Functional tests
    • [ ] License scans
    • [ ] PR title check missing
    • [ ] Missing automated releases
    • [ ] Test coverage 90%

Note: In case there are issues with any of the steps (such as failure of a license scan failure), separate issues maybe created based on the scope and nature of the issue to address it.

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • [ ] TBD [ @? ]

Done

  • [ ] Acceptance Criteria pass
  • [ ] Designs are up-to date
  • [ ] Unit Tests pass
  • [ ] Integration Tests pass
  • [ ] Code Style & Coverage meets standards
  • [ ] Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

  • [ ] TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC

ei-nghon-phoo avatar Apr 09 '24 08:04 ei-nghon-phoo

Sample current circleci run for this: https://app.circleci.com/pipelines/github/mojaloop/participants-bc/357/workflows/266b0976-7398-4f5e-a8d8-296bfa350c28 with the steps missing.

elnyry-sam-k avatar May 08 '24 08:05 elnyry-sam-k

Needs further refinement, based on further understanding of the CI/CD pipeline. @elnyry-sam-k

PaulMakinMojaloop avatar May 23 '24 10:05 PaulMakinMojaloop

Discussed today with Ei, Sam and Si Thu => Tickets can be taken up this week by Sam as he is working on the next release, nor by Si Thu as he is focussed on another internal project.

Julie asked for a re-prioritization of the tickets within ThitsaWorks'team as this ticket is a MUST HAVE to declare. vNext as a the next release candidate. Action: Ei to find that back to ThitsaWorks'executive.

JulieG19 avatar Jun 10 '24 06:06 JulieG19