project icon indicating copy to clipboard operation
project copied to clipboard

ML vnext: Basic CI/CD steps to be added and releases automated

Open elnyry-sam-k opened this issue 1 year ago • 4 comments

As a Mojaloop adopter I want all existing Mojaloop code quality and security pipeline steps to be executed against vNext repositories so that I can have the same level of confidence in a vNext based release, or any new feature implemented on the vNext codebase.

Acceptance criteria:

This epic captures several DevOps and quality related issues (not exhaustive) to be implemented to support an RC based on vnext codebase. This includes:

  1. Mojaloop vnext repos (listed below) need to have CI/CD steps similar to current Mojaloop codebase which involve:
  • Integration tests
  • Vulnerability checks
  • Image scans
  • Functional tests
  • License scans
  • PR title check
  • Automated releases CI
  • Test coverage 90%
  1. The readme pages of the documentation need to contain basic sections from the template used that consists of details to the basic description, testing, coverage, and CI/CD (Continuous Integration/Continuous Deployment) process for the following BC

  2. Beta "release" on GitHub with features covered and deployment instructions to be provided at service/BC level and bundled as a single "beta" release

  3. Main branches protected on GitHub repos with key CI steps passing on merges.

Repo list:

S No Repo
1 mojaloop/platform-shared-tools
2 mojaloop/settlements-bc
3 mojaloop/security-bc
4 mojaloop/thirdparty-api-bc
5 mojaloop/platform-configuration-bc
6 mojaloop/participants-bc
7 mojaloop/auditing-bc
8 mojaloop/foreign-exchange-bc
9 mojaloop/transfers-bc
10 mojaloop/platform-shared-lib
11 mojaloop/logging-bc
12 mojaloop/interop-apis-bc
13 mojaloop/reporting-bc
14 mojaloop/scheduling-bc
15 mojaloop/accounts-and-balances-bc
16 mojaloop/typescript-bc-template
17 mojaloop/quoting-bc
18 mojaloop/account-lookup-bc

Separate Epics for functional issues, bugs, settlement related, FSPIOP have been created.

elnyry-sam-k avatar Jan 31 '24 10:01 elnyry-sam-k

Hey team! Please add your planning poker estimate with Zenhub @JaneS321 @TW-Ei-Nghon-Phoo @bushjames @kyaw-soe-tw @SithuKyaw-Thitsaworks @zinzinnyohlaing-tw @karimjindani @PaulMakinMojaloop

elnyry-sam-k avatar Mar 20 '24 12:03 elnyry-sam-k

Hello @elnyry-sam-k , for the tech doc tasked, we have also a big epic. Can we please ensure that the twos are completely independent?

JulieG19 avatar Apr 17 '24 04:04 JulieG19

@elnyry-sam-k , can we have a clear list of acceptance criteria for this epic? For example, what does that mean to have the branch protected? and are the key steps for CI documented? Thanks a lot :)

JulieG19 avatar Apr 17 '24 04:04 JulieG19

Thanks for reviewing @JulieG19.

The four items listed are the acceptance criteria.

On the specific questions: 1) Branch protection rules are applied on primary (main currently) branches to protect against direct commits and other similar operations. 2) The key CI steps are listed in the first point.

elnyry-sam-k avatar Apr 18 '24 19:04 elnyry-sam-k