project icon indicating copy to clipboard operation
project copied to clipboard

further refine ingress subsequent to updating to networking/v1

Open tdaly61 opened this issue 3 years ago • 3 comments
trafficstars

Summary: Issues #2352 updates the ingress supplied with Mojaloop helm charts to networking/v1 but is anticipated to initially leave several tasks concerning ingress undone. The remaining items concerning ingress are

  1. turn off all non-essential ingress in the values.yaml files
  2. identify which ingress can be tested today with the TTK and turn on and test this subset of supplied ingress
  3. identify and fix any issues from item-2 above
  4. add in a disclaimer to all non-tested ingress that they have not been tested and are for example use only
  5. examine a bit more closely item-4 above because it is not clear that all of the ingress we supply would be of use to anyone in any realistic or desirable deployment scenario AND if that is true elimination of these non-functional ingress and associated configuration reduces future code maintenance requirements and improves security. [

Note the supply of numerous external http paths to mojaloop components is on the basis that an external http(s) path is or could be required to that component from outside the kubernetes cluster that the component (service) is running in. With 40 supplied ingress it seems initially unlikely that these could ever all be required to access an interact with the far more modest published Mojaloop APIs catalog at https://docs.mojaloop.io/api/.

( seems like item-5 above would a good topic for further discussion at the DA. )

Severity: high Priority: critical Expected Behavior

Notes:

  • Severity when opened: high
  • Priority when opened: high

tdaly61 avatar Oct 12 '22 22:10 tdaly61

@tdaly61 is this a bug, since this seems more like a feature?

mdebarros avatar Oct 26 '22 09:10 mdebarros

@mdebarros : well I think it depends on how we each view security and quality which I think is where we are diverging. That said I reckon over a beer or 2 we can narrow that gap :-)

tdaly61 avatar Oct 26 '22 09:10 tdaly61

Doesn't look like a bug to me, but going to refer this to the DA for further evaluation, as a feature request

elnyry-sam-k avatar May 22 '25 18:05 elnyry-sam-k