documentation icon indicating copy to clipboard operation
documentation copied to clipboard

feat: #1869 Design for reliable notifications on finalization of a transfer

Open mdebarros opened this issue 4 years ago • 1 comments

Link to story: https://github.com/mojaloop/project/issues/1869 Link to working branch: https://github.com/mojaloop/documentation/tree/feature/%231869Designforreliablenotificationsonfinalizationofatransfer/mojaloop-technical-overview/notifications

mdebarros avatar Dec 10 '20 10:12 mdebarros

Thanks @lewisdaly for the feedback!

See my inline comments below:

This looks great @mdebarros (and team).

A couple thoughts in addition to my inline comments:

  1. I would like to see examples and schemas of the NotifyCMD for other transports I would prefer to create the schema once the overall architecture approach has been given the DA node. Let me know if you feel that the definition for this schema is vital to achieving said nod.
  1. Related to the above, requiring the notification command handler is a noble goal, and to do this properly, we need to make sure we have a good understanding of the requirements so we can design the messages from the Notification Evt Handler with the appropriate level of detail. Agreed. That is exactly the kind of feedback I hope to receive from the DA. Validating the documented requirements, and also identifying any that I may have missed.

mdebarros avatar Jan 06 '21 13:01 mdebarros