Incorrect FSPIOP-Source header in a callback from switch to payerfsp - Invalid fulfillment from payeefsp case

[sri-miriyala]

In case, when the payeefsp (demomfi) is sending an invalid fulfillment, the switch is responding with an error callback to payerfsp (demowallet) only. In that response I noticed FSPIOP-Source header as "payeefsp" instead of "switch".

Expected Behavior: When there is a failure in the switch regarding a transaction (partylook up, quoting, or a transfer) the FSPIOP-Source header should be "switch". This is the case where payeefsp (demomfi) is responding (PUT) with an invalid fulfilment for a POST/transfer request.

LOGS: 2021-10-26T11:36:38.138Z - info: sendRequest::request {"url":"http://intgw.qa.preprod.myanmarpay-pre.io.internal:8844/demowallet/1.0/transfers/ec46d37a-9adb-41be-ac63-250a3cc79663/error","method":"PUT","headers":{"x-request-id":"e8e2ee625d703ebddd1876001c876423","x-real-ip":"10.233.116.0","x-forwarded-for":"10.233.116.0","x-forwarded-host":"interop-switch.qa.preprod.myanmarpay-pre.io.internal:30000","x-forwarded-port":"80","x-forwarded-proto":"http","x-scheme":"http","x-original-forwarded-for":"13.212.232.168, 10.25.131.51","date":"Fri, 22 Oct 2021 14:32:56 GMT","x-ssl-client-cert":"0","x-ssl":"1","fspiop-source":"demomfi","fspiop-destination":"demowallet","x-ssl-client-verify":"0","accept-encoding":"gzip, deflate, br","content-type":"application/vnd.interoperability.transfers+json;version=1.0","user-agent":"Synapse-PT-HttpComponents-NIO","fspiop-http-method":"PUT","fspiop-uri":"/transfers/ec46d37a-9adb-41be-ac63-250a3cc79663/error","traceparent":"00-0967fd885c23edccb61449421d440f6f-f1333691cec436db-00","tracestate":"mojaloop=eyJzcGFuSWQiOiJmMTMzMzY5MWNlYzQzNmRiIiwidGltZUFwaUZ1bGZpbCI6IjE2MzUyNDgxOTc5NTMifQ=="},"data":"{"errorInformation":{"errorCode":"3100","errorDescription":"Generic validation error - invalid fulfilment"}}","responseType":"json"} 2021-10-26T11:36:38.215Z - info: Success: sendRequest::response {"status":200,"statusText":"OK","headers":{},"config":{"headers":{},"data":"{"errorInformation":{"errorCode":"3100","errorDescription":"Generic validation error - invalid fulfilment"}}"},"request":{},"data":""}

[elnyry-sam-k]

Thanks Sri - the 'fspiop-source' header here needs to be the Switch as we discussed (as the error message originates in the Switch).. Thanks for log..

we need to raise a bug for this on mojaloop/project/issues as well to include in the normal backlog