FLINT-UI icon indicating copy to clipboard operation
FLINT-UI copied to clipboard

Migration: Migrated RothCOutput.vue to Vue 3 (Composition API)

Open kamalbuilds opened this issue 2 years ago • 17 comments

Pull Request Template

Description

Migration: Migrated RothCOutput.vue to Vue 3 (Composition API)

This PR fixes #338

Testing

Please instructions so we can verify your changes.

If our automated tests fail, please feel free to reach out to us by leaving a comment down below and we will be happy to take a look

Additional Context (Please include any Screenshots/gifs if relevant)

...

kamalbuilds avatar Sep 03 '22 16:09 kamalbuilds

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flint-ui ❌ Failed (Inspect) Oct 10, 2022 at 7:31PM (UTC)
gcbm-editor ❌ Failed (Inspect) Oct 10, 2022 at 7:31PM (UTC)

vercel[bot] avatar Sep 03 '22 16:09 vercel[bot]

@YashKandalkar Please review :smile:

kamalbuilds avatar Sep 03 '22 16:09 kamalbuilds

@Palaksharma23 can you please take a look as well?

shloka-gupta avatar Sep 05 '22 12:09 shloka-gupta

Hey! @legendarykamal, can you please work on solving the deployment errors

Palaksharma23 avatar Sep 05 '22 15:09 Palaksharma23

hey @Palaksharma23 whenever I try to access it , I get this error image

kamalbuilds avatar Sep 07 '22 15:09 kamalbuilds

@HarshCasper @chicken-biryani anything you can suggest so that I can debug this ?

kamalbuilds avatar Sep 07 '22 18:09 kamalbuilds

Hey @legendarykamal feel free to reach out to @Palaksharma23 or @Janvi-Thakkar over slack!

shloka-gupta avatar Sep 07 '22 18:09 shloka-gupta

@legendarykamal you can have a look at the CI / build run details for errors

YashKandalkar avatar Sep 08 '22 07:09 YashKandalkar

Ok @YashKandalkar i will take a peek in 🚈

kamalbuilds avatar Sep 08 '22 07:09 kamalbuilds

finally fixed the CI error :)

kamalbuilds avatar Sep 08 '22 18:09 kamalbuilds

hey @legendarykamal are you still working on it

thisiskaransgit avatar Oct 02 '22 12:10 thisiskaransgit

yeah on it @thisiskaransgit just have to fix these build errors .

kamalbuilds avatar Oct 02 '22 14:10 kamalbuilds

I rebased to fix the DCO and made changes to fix the build. Hopefully builds with no issues this time 🤞

kamalbuilds avatar Oct 10 '22 19:10 kamalbuilds

Wohoo done! all checks green @YashKandalkar @chicken-biryani @HarshCasper 💯

kamalbuilds avatar Oct 10 '22 19:10 kamalbuilds

Wohoo done! all checks green @YashKandalkar @chicken-biryani @HarshCasper 💯

Where? The Vercel deployment still fails. Please take a look at @Crystalsage's comment and fix the issue he pointed out.

HarshCasper avatar Oct 16 '22 10:10 HarshCasper

This Pull Request has not seen any activity for the past 45 days. If this Pull Request would not see any further updates in the next 10 days, it would be automatically closed. Please tag a maintainer to have it reviewed and merged for you. We truly appreciate your contributions and would love to hear your thoughts on the same!

github-actions[bot] avatar Dec 01 '22 02:12 github-actions[bot]

Hello @legendarykamal, Please do let us know if you are still working on resolving the build failures.

Janvi-Thakkar avatar Dec 04 '22 11:12 Janvi-Thakkar

Hi @thisiskaransgit! As you were asking, you may continue this.

Janvi-Thakkar avatar Dec 26 '22 18:12 Janvi-Thakkar