splink icon indicating copy to clipboard operation
splink copied to clipboard

`compare_two_records` needs to check whether tf tables exist

Open RobinL opened this issue 2 years ago • 5 comments

See https://github.com/moj-analytical-services/splink/discussions/769_

Hello! I've been trying to make use of the comparing two records feature, but I keep getting the following error: does anyone have any ideas what I'm doing wrong/ what to fix? Screen Shot 2022-09-13 at 2 43 06 PM Screen Shot 2022-09-13 at 2 42 54 PM

Originally posted by @mmagoffin-sd in https://github.com/moj-analytical-services/splink/discussions/769

RobinL avatar Sep 22 '22 09:09 RobinL

@ThomasHepworth has code from a similar issue in a PR (will be linked below)

RossKen avatar Jan 25 '23 12:01 RossKen

I believe this is partially resolved in here.

This should be relatively simple to resolve if we can reuse the code implemented above.

ThomasHepworth avatar Jan 25 '23 12:01 ThomasHepworth

It's harder than it looks because if the user just wants to compare two records, there's no guarantee they've provided Splink with a full input datasets. They might have just loaded in two records. If there is no full input dataset, we can't compute the tf tables. Instead, the user would have to provide them.

RobinL avatar Jan 29 '23 08:01 RobinL

Getting the same error trying to compare a record pair, without tf tables available

James-Osmond avatar Feb 02 '23 13:02 James-Osmond

Fixed in Splink4, see https://github.com/moj-analytical-services/splink/pull/2111

RobinL avatar Mar 28 '24 10:03 RobinL