splink
splink copied to clipboard
(WIP) Switch to ruff
Do we want the formatter to commit back, or just report on problems?
re: report/commit - I think I'm in favour of just having a pass/fail, rather than committing back changes. Been thinking about this for a while, and with autocommit:
- fiddly to get it working with forks
- confuses CI status on PRs if that's the final commit
- end up with loads of noise commits - if I pushed a change that failed the lint, providing PR is in early stage I would prefer to amend my commits + repush. With the 'lint with black' type commit this is more of a pain, and probably wouldn't bother, so just more noise.
Don't feel super strongly, but think that would be my preference. Could potentially encourage devs to include a ruff --fix
pre-commit hook to catch a bunch of stuff?
Yeah, agree. I find auto commit pretty annoying!