moira icon indicating copy to clipboard operation
moira copied to clipboard

Fill message templates in logs

Open androndo opened this issue 4 years ago • 1 comments

PR Summary

Added filling messageTemplate for log methods with format, this allow to aggregate messages by this fileds. It useful for Sentry, Kibana or some log viewvers.

androndo avatar May 31 '21 14:05 androndo

Codecov Report

Merging #636 (4f5d962) into master (1f1d72e) will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   69.25%   69.22%   -0.03%     
==========================================
  Files         170      170              
  Lines        7624     7624              
==========================================
- Hits         5280     5278       -2     
- Misses       2010     2012       +2     
  Partials      334      334              
Impacted Files Coverage Δ
database/redis/database_dialer.go 45.83% <0.00%> (-2.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f1d72e...4f5d962. Read the comment docs.

codecov-commenter avatar May 31 '21 14:05 codecov-commenter

we have already rewritten the logs https://github.com/moira-alert/moira/pull/819 https://github.com/moira-alert/moira/pull/816

kissken avatar Feb 10 '23 11:02 kissken