moira-alert
Fix linter issues
Moira is using golangci-lint to check code. Unfortunately we have a bunch of code from the times before we started to use linters and because of that we had to disable some linters.
You have a chance to help us to improve our code quality fixing linter issues.
I created a branch called feature/lint-hacktoberfest. You can fork it and fix issues in files.
To contribute you can use following steps:
- Fork project and branch
feature/lint-hacktoberfest - Open any file that have
//nolint:at the beginning of the file and remove//nolint: - Fix linter issues
- Make commit
- Create PR
- Profit!
I can't find branch feature/lint-hacktoberfest. How should I actually contribute?
@litleleprikon i would like to work on this issue, can you please assign it to me? PS: i have already setup the repo
Hello @litleleprikon i am super excited to work on this issue if anyone still no assigned.
I was checking on the issue. But there was no feature/lint-hacktoberfest branch. Will working in the master branch be okay @litleleprikon?
@alishamohanty @shashikant231 @adrijshikhar OK, now we have the feature/lint-hacktoberfest branch with all linters enabled. As expected, it generates a lot of linter errors. You are welcome to try and fix them. Please, keep different linter fixes in different PRs, so multiple people can work on this issue in parallel.
Alright @beevee .i will start from now on!!
On Mon, 16 Mar 2020 at 01:35, Alisha Mohanty [email protected] wrote:
Okay, @beevee https://github.com/beevee, Working on it. Keeping you posted here.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/moira-alert/moira/issues/446#issuecomment-599257616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALP46BIWKC65IJJYJFUYS5DRHUYKNANCNFSM4JCJRVDA .
