moira icon indicating copy to clipboard operation
moira copied to clipboard

[ telegram sender ] bad redis key naming / key storing

Open kamaev opened this issue 5 years ago • 3 comments

  • connector.RemoveUser is never being used (except for tests)
  • non-unique chat titles are not allowed: https://github.com/moira-alert/moira/blob/1084b514bb3fe7b73b7a69adb305eb04590a62aa/senders/telegram/handle_message.go#L37

kamaev avatar May 30 '19 09:05 kamaev

HI @kamaev @beevee can you plz elaborate what it means by "non-unique chat titles are not allowed?

shashikant231 avatar Mar 03 '20 19:03 shashikant231

HI @kamaev @beevee can you plz elaborate what it means by "non-unique chat titles are not allowed?

Sure. When a Telegram user creates a subscription to a private group, notification channel is specified by the group title. Of course, different private groups in Telegram can have identical titles, but Moira doesn't allow this.

beevee avatar Mar 04 '20 10:03 beevee

@beevee one possible solution would be: inform the user about existing group-name after /start so that it can be renamed. What do you say?

hv7214 avatar Mar 27 '20 14:03 hv7214