moira icon indicating copy to clipboard operation
moira copied to clipboard

Change color and state of metric when turn on the maintenance

Open usbulat opened this issue 6 years ago • 14 comments

Hello,

Is there any way to change color and state of metric when turning on the maintenance? For example, if we have error (red) state for some metric but we turn maintenance for it (because we wan't to ignore it for some time), as I understand we won't get any notification for it. But is it possible to change state from error to another?

usbulat avatar Jun 27 '18 09:06 usbulat

Hi, Bulat! No, in this case Moira keeps metric's last state to show actual state change at the expiration of maintenance period. But, if you're using some automation to control moira triggers (ex.: https://github.com/moira-alert/moira-trigger-role or api client) you can use trigger expression parameter instead of (warn/error limits)&maintenance.

trigger with params WARN >= 1; ERROR >= 10 will be checked equally as
trigger with expression "t1 >= 10 ? ERROR : (t1 >= 1 ? WARN : OK)"

For example:

You have trigger with expression "t1 >= 10 ? ERROR : (t1 >= 1 ? WARN : OK)" and you want to do something so many unwanted alerts can be produced, but you need the trigger to be "OK". So you can simply change current expression to "OK". But don't forget to set required trigger state in case when Moira has no metrics received (ttl_state). Otherwise you'll be notified in case of NODATA.

kamaev avatar Jun 27 '18 10:06 kamaev

Thank you, @kamaev !

In this case, is it possible to make this way:

  • we turn maintenance for some error (red) metric on screenshot
  • this metric doesn't change its color and state in "Current state" area, but in this area: screenshot 1 we will have this view: screenshot 2

I mean just to make another view for counts of error/ok/warn area - to add for example "blue" counter for maintenance.

If this is not possible, could we make a month period request? Or is there another soultion to solve it?

usbulat avatar Jun 29 '18 10:06 usbulat

So, what we decide, guys? I hate open issues

sashasushko avatar Jul 20 '18 03:07 sashasushko

@borovskyav Please, check this out

kamaev avatar Jul 20 '18 07:07 kamaev

Talked to Arkady, we decided to keep this issue open (sorry, Sasha!) 2.3 release is coming soon so we unfortunately have finite number of tasks to close. But we will definitely add the monthly maintenance option in future releases. Task to show colorized counter of metrics with maintenance turned on takes more discussion since we have some issues with its realization.

kamaev avatar Jul 20 '18 09:07 kamaev

@usbulat I remember our talk :) We'll get to this task soon.

beevee avatar Dec 03 '18 11:12 beevee

@borovskyav says it's planned for 2.5

beevee avatar Dec 03 '18 11:12 beevee

@borovskyav says it's planned for 2.5

Hi. Thank you so much.

usbulat avatar Dec 03 '18 11:12 usbulat

@beevee Hi, when is 2.5 release date planned?

usbulat avatar Dec 05 '18 15:12 usbulat

@borovskyav раз добавил в 2.5, опиши задачу, что изменится и как будет?

sashasushko avatar Feb 01 '19 09:02 sashasushko

Давайте на летучке в понедельник вместе подумаем, у меня есть несколько решений, но я не могу выбрать между сортами)

borovskyav avatar Feb 01 '19 18:02 borovskyav

на летучке в понедельник вместе подумаем

@borovskyav запиши себе на мартовское планирование, плез

sashasushko avatar Feb 25 '19 13:02 sashasushko

HI @sashasushko can i take this issue?

shashikant231 avatar Mar 03 '20 16:03 shashikant231

Let's first ask @borovskyav about task specification

sashasushko avatar Mar 04 '20 06:03 sashasushko