moira icon indicating copy to clipboard operation
moira copied to clipboard

fix(linter): Upgrade and add some linters

Open kissken opened this issue 1 year ago • 1 comments

fix(linter): Upgrade and add some linters

kissken avatar Jul 18 '24 16:07 kissken

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.39130% with 60 lines in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (1f2b4ac) to head (ef5929e). Report is 35 commits behind head on master.

Files Patch % Lines
datatypes.go 35.00% 13 Missing :warning:
api/dto/team.go 0.00% 7 Missing :warning:
senders/slack/slack.go 33.33% 4 Missing :warning:
api/handler/triggers.go 0.00% 3 Missing :warning:
database/redis/reply/trigger.go 0.00% 3 Missing :warning:
api/handler/contact_events.go 33.33% 2 Missing :warning:
cmd/api/config.go 71.42% 2 Missing :warning:
cmd/cli/from_2.9_to_2.10.go 0.00% 2 Missing :warning:
cmd/cli/main.go 0.00% 2 Missing :warning:
database/redis/last_check.go 0.00% 1 Missing and 1 partial :warning:
... and 18 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   67.92%   67.33%   -0.59%     
==========================================
  Files         212      215       +3     
  Lines       12024    12407     +383     
==========================================
+ Hits         8167     8354     +187     
- Misses       3359     3527     +168     
- Partials      498      526      +28     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 18 '24 16:07 codecov-commenter

see https://github.com/moira-alert/moira/pull/1167

kissken avatar Apr 03 '25 11:04 kissken