moin icon indicating copy to clipboard operation
moin copied to clipboard

check sdist package contents

Open ThomasWaldmann opened this issue 7 years ago • 1 comments

#597 changed the way the package contents are determined.

"everything tracked in git" is the default rule implemented by setuptools_scm, so we only need to care for exceptions from that in MANIFEST.in.

TODO: verify the contents of the sdist, is all we need in there?

esp. translation files, css / js and other web files come to mind.

practically test the usability of the sdist (pip/pypi package) in a clean env.

ThomasWaldmann avatar Aug 29 '18 15:08 ThomasWaldmann

python setup.py sdist
# result is in dist/...

ThomasWaldmann avatar Aug 30 '18 10:08 ThomasWaldmann

Moin package from test.pypi.org can be installed successfully. Is there anything left to do?

UlrichB22 avatar Sep 02 '23 20:09 UlrichB22

MANIFEST.in needs an update (at least .travis.yml should be removed).

Also, the created sdist might have unwanted files in it (files that are git committed, but not wanted in an sdist).

@UlrichB22 If you tested the pypi package and it fully works, guess at least any not-committed but wanted file is contained in there.

ThomasWaldmann avatar Sep 03 '23 12:09 ThomasWaldmann

Except for the 'travis' leftover I did not find any unnecessary files in the sdist.

UlrichB22 avatar Sep 03 '23 20:09 UlrichB22