moin icon indicating copy to clipboard operation
moin copied to clipboard

html validation error, malformed uri reference

Open RogerHaase opened this issue 4 years ago • 3 comments

Links with non Ascii characters are not properly escaped. Add the following to a moinwiki item and run html validator.

[[AjudaNaFormatação]]

RogerHaase avatar Oct 28 '21 14:10 RogerHaase

In converter/link.py near line 188, an example url value passed to

link = Iri(url, query=query, fragment=input.fragment)

is '/AjudaNaFormata%C3%A7%C3%A3o', the link value returned is '/AjudaNaFormatação' causing the error.


In converter/htmlout.py, near line 76:

elem.attrib[html.data_href] = href

a sample href value is '/AjudaNaFormatação' which is not properly encoded, causing the error.

RogerHaase avatar Nov 03 '21 14:11 RogerHaase

Discovered yesterday that this issue was prefixed with the error message "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository."

The uri-1137 branch with the patch applied was still on my local repo. So I checked out the branch, pulled updates from the moinwiki master repo, ran 'm coding-std' to remove a blank line from the end of common.css, did a commit, and pushed to my github repo. All seems well but haven't pushed to moinwiki repo yet.

RogerHaase avatar Mar 07 '22 18:03 RogerHaase

Closed the pull request without update; got a traceback with [[#Link]]

RogerHaase avatar Mar 10 '22 16:03 RogerHaase