pcompress icon indicating copy to clipboard operation
pcompress copied to clipboard

init_on_disk_index(): broken stub

Open nickb937 opened this issue 10 years ago • 1 comments

This patch introduced a change to init_on_disk_index(), which appears as a stub function calling file_exists() incorrectly.

https://github.com/moinakg/pcompress/commit/0433452b3745db84e39d430bde63a921793c647e#diff-2ceb6d73d3458e52af971d891a90f81f

rabin/global/index.c: In function ‘init_on_disk_index’: rabin/global/index.c:79:9: error: too few arguments to function ‘file_exists’ if (file_exists()) { ^ In file included from rabin/global/index.c:37:0: ./utils/utils.h:351:12: note: declared here extern int file_exists(char *path); ^ rabin/global/index.c:82:1: warning: control reaches end of non-void function [-Wreturn-type] } ^

nickb937 avatar Jun 10 '14 10:06 nickb937

Thanks, I accidentally committed an un-buildable change.

On Tue, Jun 10, 2014 at 3:50 PM, Nick Burrett [email protected] wrote:

This patch introduced a change to init_on_disk_index(), which appears as a stub function calling file_exists() incorrectly.

0433452#diff-2ceb6d73d3458e52af971d891a90f81f https://github.com/moinakg/pcompress/commit/0433452b3745db84e39d430bde63a921793c647e#diff-2ceb6d73d3458e52af971d891a90f81f

rabin/global/index.c: In function ‘init_on_disk_index’: rabin/global/index.c:79:9: error: too few arguments to function ‘file_exists’ if (file_exists()) { ^ In file included from rabin/global/index.c:37:0: ./utils/utils.h:351:12: note: declared here extern int file_exists(char *path); ^ rabin/global/index.c:82:1: warning: control reaches end of non-void function [-Wreturn-type] } ^

— Reply to this email directly or view it on GitHub https://github.com/moinakg/pcompress/issues/19.

http://moinakg.wordpress.com/ http://moinakg.github.com/pcompress/

moinakg avatar Jun 11 '14 06:06 moinakg