moi15moi
moi15moi
@tkarabela What do you think about my previous message?
I don't really know where to add it properly. I thought about [time.py](https://github.com/tkarabela/pysubs2/blob/master/pysubs2/time.py), but since the new class I proposed contain **frames_to_ms** and **ms_to_frames** method, we need to change all...
> This would make sure that timestamps are properly "snapped" to timestamps in the output file, while requiring little modification to other code. Would that be useful? Not really, the...
> The conversion from SRT -> ASS should be improved as of version 1.6.0 of the library after this commit: [2725c0a](https://github.com/tkarabela/pysubs2/commit/2725c0a000f4ad5cc9255e262743ee6c2681da5f) This isn't really a magic method that make the...
> The test data is here: [pysubs2_timestamps_test.zip](https://github.com/tkarabela/pysubs2/files/10418625/pysubs2_timestamps_test.zip) The file ``test_video.mp4`` is a bit strange since it doesn't round the timestamps. Ex: for the image 1, it should be 42 ms,...
> Sorry, by "snapping to frame" I didn't mean the simple rounding as you do in `round_timing` (that's already implemented, and I see it why it doesn't really help) I...
> I've tried with the first 23.976 video example: See the message where I presented the example where the fps = 93, the end_time correspond to the frame 37 and...
Is there any problem?
In my case, it would be .ass to .vtt file, but of course, .vtt to .ass is needed. I don't know it if it can help you, but I have...
VLC also only parse the fps when it has this format: "{1}{1}THE_FPS" Reference: https://code.videolan.org/videolan/vlc/-/blob/dccda0e133ff0a2e85de727cf19ddbc634f06b67/modules/demux/subtitle.c#L1014