NppMarkdownPanel icon indicating copy to clipboard operation
NppMarkdownPanel copied to clipboard

Small but useful changes

Open andrzejQ opened this issue 2 years ago • 3 comments

I've added small but useful changes, such as suggesting a name when writing to HTML, and filtering before displaying with regular expressions. I have no experience with C#, so you can close this pull request without an answer.

andrzejQ avatar Jun 03 '22 11:06 andrzejQ

Newer v. RegExp 0.6.2.1

andrzejQ avatar Jun 04 '22 06:06 andrzejQ

There are differences - so I do not understand "no conflicts"...

andrzejQ avatar Jun 06 '22 09:06 andrzejQ

Thanks for creating a PR. I hope i can review your changes next week. I dont see a problem when there are no conflicts, so everything seems to be compatible.

mohzy83 avatar Jun 06 '22 15:06 mohzy83

Unfortunately, this PR is not compatible with the current master. Therefore I am going to close this one.

already implemented in master:

  • Save As UTF-8
  • MarkdownPreviewForm.cs:

at the end, no

known issus:

  • Link handling (solution in this PR doesn't work anymore, cause markdig is used as external lib)
  • auto save is not implemented yet

not clear

  • why was the regexp handling implemented?

mohzy83 avatar Dec 13 '22 15:12 mohzy83

Unfortunately, this PR is not compatible with the current master. Therefore I am going to close this one.

Ok.

not clear

  • why was the regexp handling implemented?

Pre-converting text using RegExp allows "non-standard" Markdown expressions to be displayed correctly, e.g. {style} instead of {:style} (Jekyll).

andrzejQ avatar Dec 14 '22 05:12 andrzejQ