Mohammad Rezaei
Mohammad Rezaei
FYI, [this](https://github.com/rust-lang/rust/issues/56009) is making things a bit difficult.
So I need a little help/sounding board here. After looking more closely at the performance, I have two different 64-bit implementations (perfect_hash, lz) that behave like so: RUSTFLAGS="" perfect_hash: 9000...
I agree that vectorization is not an important consideration. When I turn off vectorization, lz benefits from native, but perfect_hash does not. I was also worried about 32bit platforms, but...
This should be a good basis for a full review. I did a `cargo fmt` just on the new files. The arrays became quite long, but I left them as...
@cuviper ping, just in case this got lost in the holiday shuffle :smile:
Renamed floor_log10 to log10 and added checked/unchecked variants (wrapping didn't make sense?). Also made sure tests pass in release mode. BTW, interesting curiosity: `0f64.log10().floor() == 0` (would've made a good...
Right, sorry, this got me confused: ```0f64.log10().floor() as u32 == 0``` [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4bc907f11216d7d087725a1be137412c)
The last commit should address the latest review comments. Let me know if there is more to do (I'll squash the commits once the review is done). Oh, I should...
It was the zero panic. Pushed a fix. BTW, the always panic behavior has a 50% cost in performance for u32 (from 0.8 ns per call to 1.2 ns per...
Shouldn't the conversion to unmodifiable do the compacting?