rearrange-tabs icon indicating copy to clipboard operation
rearrange-tabs copied to clipboard

Chrome 69 address bar bug

Open corysimmons opened this issue 6 years ago • 15 comments

Highlight address bar.

Alt/Option + Shift + <-- should do word selection stuff. Instead it now shifts tabs around.

Thanks for helpful extension. I use it all the time.

corysimmons avatar Sep 05 '18 06:09 corysimmons

@corysimmons I've noticed this just now. Thanks for raising this issue. It seems like something around the shortcuts changed in Chrome 69. The only thing I can currently think of is that Chrome probably has started considering the default key from the manifest.json file. That's the only place Alt+Shift+<arrow> key combination is used (for Mac). I'll try removing it and test it locally and test it. If that works, I'll ship it out as soon as I can. Once again, thanks for raising the issue and I'm glad you find the extension helpful. Cheers!

mohnish avatar Sep 05 '18 17:09 mohnish

Wow, great maintainer! 🙌

corysimmons avatar Sep 05 '18 18:09 corysimmons

+1 Love this extension, btw

dutzi avatar Oct 03 '18 15:10 dutzi

I temporarily overridden the shortcut in chrome://extensions/shortcuts Currently using: cmd + shift + left / cmd + shift + right

lucas-janon avatar Oct 24 '18 22:10 lucas-janon

I've noticed something weird in Chrome 70. For those who haven't overridden the default shortcut, when you hit Shift+Alt+<arrow> from the URL bar, followed by just the Shift key or just the Alt key, the browser actually highlights the text you want to highlight in the URL bar (It still moves your tab around as a side effect). I'm still not sure what would cause this behavior.

mohnish avatar Oct 25 '18 00:10 mohnish

This is not a fix, but for some reason, changing the second dropdown from "In Chrome" to "Global" solves the address bar issue.

emiljohansson avatar Oct 25 '18 15:10 emiljohansson

@emiljohansson that can be programatically done. I was actually looking into that option yesterday. I’ll implement it locally and see if it works. Thanks for your input.

mohnish avatar Oct 25 '18 16:10 mohnish

Ok, looks like Global option is not really the right path since the shortcut triggers the extension even when Chrome is not in focus. Here's the doc https://developer.chrome.com/extensions/commands#scope

mohnish avatar Oct 25 '18 21:10 mohnish

I've reached out to Chrome Dev team and I haven't received any response back.

During debugging and testing, I tried switching the shortcut keys for Mac from Ctrl+Shift+Left/Right/Up/Down to Ctrl+CMD+Left/Right/Up/Down. This worked like a charm.

Pros

  • This will fix the issue and since Ctrl+CMD+Left/Right/Up/Down is not used for editing text

Cons

  • Besides the fact that this will break the extension for the existing users, the existing users will also have to get used to the new shortcuts.

So, I'm trying to decide if the change is worth it.

mohnish avatar Jan 16 '19 02:01 mohnish

Add those shortcuts and add a place in the extension to change the shortcut to whatever the user wants. In that area, link to this issue.

If anyone complains, carve their heart out with a spoon.

corysimmons avatar Jan 16 '19 02:01 corysimmons

Appreciate the feedback, @corysimmons!

I think I'll add a pop-up or something similar that shows up once the extension is updated. That way it'd be easier to let the existing users know of the change.

mohnish avatar Jan 17 '19 19:01 mohnish

I've reached out to Chrome Dev team and I haven't received any response back.

Is there any public information about this? Did you create a bug report or something?

In addition, if you decide to replace Ctrl ⌃ with Command ⌘ on macOS in the end, you can omit both windows and mac variants because the default would just work (Ctrl in default will be converted to Command ⌘ in mac).

FranklinYu avatar Aug 15 '19 04:08 FranklinYu

This is still happening @mohnish.

johangithub avatar Sep 27 '19 01:09 johangithub

Still having this issue on OSX. I love this extension but can't use it with this bug.

DaveAllbirds avatar Feb 02 '22 20:02 DaveAllbirds

@DaveAllbirds Hi Dave! 👋

You can always change the shortcut to CTRL+CMD+<arrow_key> to avoid this issue. Hope that helps, cheers!

mohnish avatar Feb 02 '22 21:02 mohnish

I am also desperately waiting for a fix here. I have tried the other methods, nothing works seamlessly on Mac.

giray123 avatar Oct 06 '22 12:10 giray123

Addressed in https://github.com/mohnish/rearrange-tabs/pull/52

mohnish avatar Feb 14 '23 20:02 mohnish