check-engine

check-engine copied to clipboard

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits 7efb22a 1.2.6 ef88b93 security notice for additional prototype pollution issue c2b9819 isConstructorOrProto adapted from PR bc8ecee test from prototype pollution PR See full...

dependabot[bot]

We are currently returning -1 when the checking system fails. We should also return a positive number of failed checks so that users can do command line expressions such as:...

kwpeters

See https://github.com/thaliproject/Thali_CordovaPlugin/blob/vNext_yarong_1028/thali/install/validateBuildEnvironment.js#L276

mohlsen

**Suggestion** To prevent too much noise on output, add an option `--quiet` to omit successful output. Error output could be display as is.

richard-lopes-ifood

create a logo

3

@kwpeters gets credit for this! check-engine makes for some great logo opportunities! Would be great to combine it with the node.js hexagon and the traditional check engine light. https://www.google.com/search?q=check+engine+light&source=lnms&tbm=isch

mohlsen

I recently had a bug because the version of [angular-cli](https://github.com/angular/angular-cli) changed and I don't see it. So a support with sevmer should be nice.

bastienmoulia

We need to make sure that these two specify the same version of Node.js

kwpeters

Returned status redundancy

1

The value resolved from the package's exported function contains a `status` that is 0 (if successful) or -1 (otherwise). Also, the `message` object has a `type` field that is either...

kwpeters

The `cordova -v` command returns text about telemetry, then the version number. So our validator fails even if the version is ok.

mohlsen

implement asynchronous reporting of packages

1

so the caller can get results as they come in

mohlsen