react-native-copilot
react-native-copilot copied to clipboard
Add onPress support in the middle of steps
This PR only works with copilot with overlay: 'view'
.
This is how we can use it:
const CopilotTouchableOpacity = walkthroughable(TouchableOpacity)
...
<CopilotStep text="some text" order={1} name="someName">
<CopilotTouchableOpacity
onPress={someFunction}
>
...
</CopilotTouchableOpacity>
</CopilotStep>
note:
since I think RTL is a must have, I've not made a new branch from master
but this a branch from rtl
branch I sent for you yesterday.
Could you please provide some more insight on this? What were you trying to achieve? I'd suggest any PR that introduces a new feature should have to add a short howto to the readme.
@mohebifar I need some time to come up with a good explanation. I'll let you know when that happened.
@iamsoorena Any chance you have found some time for this? :)
@RichardLitt I'm so sorry for the delay. I'll do it this week.
There's no rush! Just curious. :)
@RichardLitt I've added description to Readme. If there's anything else, let me know.
LGTM @iamsoorena, thanks again. I just added a few comments.
@mohebifar Where can I find your comments? Should I change sth?!
@mohebifar Did you forget to click "Review changes" after making comments? Sometimes, that leads to them not being posted.
Yes, sorry for that. Just submitted.
This would be epic! Any chance this can get resolved sooner rather than later? :)
Awesome lib btw :fist_oncoming:
@iamsoorena Could you please look into this again?
Guys any update on this? Being able to interact with the guide is crucial for the guide flow itself. This is an awesome library.
This looks soo close to being ready to add. Is there anything I can do to help get this implemented in the library?
@mikefogg Do you think you can own this i.e. address the comments, rebase, and open a new PR?
hello guys, I'm currently testing this lib in our app and we need a feature to let people click on the highlight step
I've already made a change to detect clicks inside the mask highlight and outside it. I've seen that the original author here just made a change to let the component pass the original click function.
@mohebifar do you think that my approach to let people click on the highlight mask is better or worse than this approach to just enable the original component click?
The original author approach seems better to not duplicate the click function, but my approach has versatility because we can just change the click behavior on copilot wrapped components (instead of following the original component click)
If you want I can open a PR based on this approach, or change it to respect the original author approach (I'm redoing everything, not just rebasing and fixing the comments above)
@mikefogg @gilsonviana @danstn ☝️
do you think that my approach can handle your use case?