react-native-copilot icon indicating copy to clipboard operation
react-native-copilot copied to clipboard

Add onPress support in the middle of steps

Open iamsoorena opened this issue 5 years ago • 17 comments

This PR only works with copilot with overlay: 'view'. This is how we can use it:

const CopilotTouchableOpacity = walkthroughable(TouchableOpacity)
...
<CopilotStep text="some text" order={1} name="someName">
  <CopilotTouchableOpacity
    onPress={someFunction}
  >
    ...
  </CopilotTouchableOpacity>
</CopilotStep>

note: since I think RTL is a must have, I've not made a new branch from master but this a branch from rtl branch I sent for you yesterday.

iamsoorena avatar Sep 02 '18 08:09 iamsoorena

Could you please provide some more insight on this? What were you trying to achieve? I'd suggest any PR that introduces a new feature should have to add a short howto to the readme.

mohebifar avatar Sep 14 '18 18:09 mohebifar

@mohebifar I need some time to come up with a good explanation. I'll let you know when that happened.

iamsoorena avatar Sep 18 '18 07:09 iamsoorena

@iamsoorena Any chance you have found some time for this? :)

RichardLitt avatar Nov 07 '18 17:11 RichardLitt

@RichardLitt I'm so sorry for the delay. I'll do it this week.

iamsoorena avatar Nov 09 '18 07:11 iamsoorena

There's no rush! Just curious. :)

RichardLitt avatar Nov 09 '18 13:11 RichardLitt

@RichardLitt I've added description to Readme. If there's anything else, let me know.

iamsoorena avatar Nov 12 '18 09:11 iamsoorena

LGTM @iamsoorena, thanks again. I just added a few comments.

mohebifar avatar Nov 16 '18 15:11 mohebifar

@mohebifar Where can I find your comments? Should I change sth?!

iamsoorena avatar Nov 17 '18 10:11 iamsoorena

@mohebifar Did you forget to click "Review changes" after making comments? Sometimes, that leads to them not being posted.

RichardLitt avatar Nov 20 '18 01:11 RichardLitt

Yes, sorry for that. Just submitted.

mohebifar avatar Nov 20 '18 01:11 mohebifar

This would be epic! Any chance this can get resolved sooner rather than later? :)

Awesome lib btw :fist_oncoming:

danstn avatar Jul 03 '19 02:07 danstn

@iamsoorena Could you please look into this again?

mohebifar avatar Jul 04 '19 14:07 mohebifar

Guys any update on this? Being able to interact with the guide is crucial for the guide flow itself. This is an awesome library.

gilsonviana avatar Jan 24 '20 20:01 gilsonviana

This looks soo close to being ready to add. Is there anything I can do to help get this implemented in the library?

mikefogg avatar May 13 '20 01:05 mikefogg

@mikefogg Do you think you can own this i.e. address the comments, rebase, and open a new PR?

mohebifar avatar May 18 '20 21:05 mohebifar

hello guys, I'm currently testing this lib in our app and we need a feature to let people click on the highlight step

I've already made a change to detect clicks inside the mask highlight and outside it. I've seen that the original author here just made a change to let the component pass the original click function.

@mohebifar do you think that my approach to let people click on the highlight mask is better or worse than this approach to just enable the original component click?

The original author approach seems better to not duplicate the click function, but my approach has versatility because we can just change the click behavior on copilot wrapped components (instead of following the original component click)

If you want I can open a PR based on this approach, or change it to respect the original author approach (I'm redoing everything, not just rebasing and fixing the comments above)

iujisato avatar Oct 06 '20 20:10 iujisato

@mikefogg @gilsonviana @danstn ☝️

do you think that my approach can handle your use case?

iujisato avatar Oct 06 '20 20:10 iujisato