Mohamad Mohebifar

Results 56 comments of Mohamad Mohebifar

That sounds good! But I'd say let's keep `wasSkipped`. Would like to do that? If so, feel free to update this PR, otherwise, we can close it and I'll try...

Where is `wasSkipped` passed into `handleStop`?

I tested your branch and it doesn't seem to pass wasSkipped correctly until you change the skip button's code in `Tooltip.js` to the following: ```js { !isLastStep ? handleStop(true)}> Skip...

That's interesting. I had never tried using non-text elements in the tooltip. The algorithm for computing the dimensions and the position of the modal lays [here](https://github.com/okgrow/react-native-copilot/blob/master/src/components/CopilotModal.js#L101) which obviously needs to...

Yes, looking at the screenshots you shared, it seems to be that `OFFSET` thing. If you'd like to make that customizable, PRs are welcome!

@iamsoorena Thanks! I'm on a vacation right now. I'll test and review this next week.

@iamsoorena Sorry for the delay on reviewing this. This looks really good! Thank you. I'm just curious if it is possible to programmatically switch the direction. For example, when changing...

This looks good to me. I would just like to know if the programmatic change of direction is a possibility. In that case, we would have to move the RTL...

Seems that #82 includes these changes as well as the `onPress` thing. It would be better if the PRs only introduce one new feature or bug fix. But for now,...

@iamsoorena Just wanted to follow up with you to see if you want still would like to: 1. Make the change to check the direction dynamically in the `measure`ment code....