MDIncrementalImageView
MDIncrementalImageView copied to clipboard
Cleaned up code and hide non-public data
Clean up some code to remove a bunch of stuff that doesn't need to be public.
Fixed cleanUp code to actually clean up everything. Changed member variables access from "_" to "self." style.
Signed-off-by: Scott Gustafson [email protected]
Please delete the control , i tried to delete it but couldn't , you guys should make a delete button for controls !
Thanks
On Mon, Dec 8, 2014 at 10:32 PM, Scott Gustafson [email protected] wrote:
Clean up some code to remove a bunch of stuff that doesn't need to be public.
Fixed cleanUp code to actually clean up everything. Changed member variables access from "_" to "self." style.
Signed-off-by: Scott Gustafson [email protected]
You can merge this Pull Request by running
git pull https://github.com/scott-42/MDIncrementalImageView master
Or view, comment on, or merge it at:
https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1 Commit Summary
- Clean up some code to remove a bunch of stuff that doesn't need to be public.
File Changes
- M Classes/MDIncrementalImageView.h https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1/files#diff-0 (17)
- M Classes/MDIncrementalImageView.m https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1/files#diff-1 (123)
- M MDIncrementalImageView Demo/MDIncrementalImageView Demo/ViewController.m https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1/files#diff-2 (2)
Patch Links:
https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1.patch
- https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1.diff
— Reply to this email directly or view it on GitHub https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1.
I don't understand your request to delete the control. Are you wanting to remove your git repo?
sorry , i thought you are some one else ,if you want to modify the repository , please fork it .
On Mon, Dec 8, 2014 at 10:49 PM, Scott Gustafson [email protected] wrote:
I don't understand your request to delete the control. Are you wanting to remove your git repo?
— Reply to this email directly or view it on GitHub https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1#issuecomment-66184506 .
Are you new to GitHub? I've already forked it, fixed the code and this is a pull request for you to integrate the code back into the main repo if you want. You can see the current list of forks from the main repo page.
sorry for the misunderstanding ,Thanks any way for the pull request ,i appreciate your interest in this repository .
its just this repository was just for playing around with ImageIO framework to load images progressively , but found out that using imageIO framework the memory seems to spike considerably and unexpectedly during downloading the image ,may be you can find out why ,and let me know , may be the solution is to use NSStream objects like (NSInputStream and NSOutputStream) to download the image.
Thanks again
On Tue, Dec 9, 2014 at 9:55 AM, Scott Gustafson [email protected] wrote:
Are you new to GitHub? I've already forked it, fixed the code and this is a pull request for you to integrate the code back into the main repo if you want. You can see the current list of forks from the main repo page.
— Reply to this email directly or view it on GitHub https://github.com/mohammedDehairy/MDIncrementalImageView/pull/1#issuecomment-66246393 .