Mohammad Sekhavat

The diff seems to be empty now. I think https://github.com/apple/corenet/pull/15/commits/ecbece3c603777e3523620cc9f5bc204e9778990 looked good except line 92

Hi @CarreraPHP @rezashahnazar and @michaelrrrrrr, Thank you for bringing this into our attention and thank you for your suggestions. My understanding from your suggestions is that the `torchtext==0.17.1` dependency fails...

Hi @hub-bla . Thank you for your contribution. Since freeze_modules accepts regex, I'm wondering if a more flexible regex could select nested modules with the existing code? For example, the...

I see where you are coming from! I agree that the `# TODO: allow applying on all modules, not just immediate chidren? How?` is confusing. I think the TODO is...

Freezing modules (i.e. disabling `.train()`) is different with freezing parameters (i.e. setting `requires_grad=False`). As this issue is closely related to #10 , I'm closing this one.

Hi again, Quick update - I don't have a clean solution for resolving the TODO for skipping nested train/eval calls at the moment. Please feel free to re-open/update this issue...

Hi all, We've just merged #37 , which should fix this issue. I'm closing this issue, but please feel free to re-open it if you face issues with `torchtext==0.17.2`

Closing for inactivity. Please feel free to re-open it after updating the PR.