KissThreading.jl
KissThreading.jl copied to clipboard
ThreadingTools.jl
@mohamed82008 @bkamins I was thinking about how to add some features and address some limitations with KissThreading:
- Only require associativity with
mapreduce - Compatibility with exotic array types e.g.
OffaxisArrays - Add
sum, reduce...convenience functions - Use
Baseversions on each thread (e.g.Base.sumis more precise andBase.maximumis faster then a naive fallback to mapreduce)
and realized, that doing so would require more or less a rewrite. Instead of doing a PR, I created
ThreadingTools. So what should we do with it? If you like it, I would be happy to merge it into KissThreading. If not I would like to release it.
I am ok with merging them :)
If there are changes that can make KissThreading faster, more general and more convenient to use, I fully support them!
Okay nice, then the plan is to merge. There are some things that need to be sorted out:
- I use
ThreadingTools.mapsyntax where here we usetmap. I have a slight preference for the former style, but can live with the latter also. Which one do you want? - It would be cool to have commit access to
KissThreading. Would that be okay with you?
Which one do you want?
We can have both const tmap = KissThreading.map.
It would be cool to have commit access to KissThreading. Would that be okay with you?
Sure!
Invitation sent.
Invitation sent.
Thanks!
We can have both
const tmap = KissThreading.map.
Mhh yeah that's true. But I think its better to have one way instead of two. We can go with just tmap if you like.