KissThreading.jl icon indicating copy to clipboard operation
KissThreading.jl copied to clipboard

KissThreading relies on @threads implementation details

Open jw3126 opened this issue 6 years ago • 2 comments

See here. This applies to tmap, tmapreduce, getrange. Especially getrange is broken, it will give wrong results if a threadid is used multiple times.

jw3126 avatar Jun 18 '19 12:06 jw3126

I don't think tmap and tmapreduce make any assumption about the threadid. getrange is not used anywhere.

mohdibntarek avatar Jun 20 '19 15:06 mohdibntarek

tmap and tmapreduce are correct, but waste performance. I cannot imagine a non broken use case of the current getrange. It is used in the tests and all uses in the tests are broken.

jw3126 avatar Jun 20 '19 16:06 jw3126