Merging with Tihu

[b00f]

Can you merge this into Tihu project? I am frequently receiving email (mostly from the non-Persian that wants to learn Persian) and they are complaining about G2P module in Tihu. It is old and not working working with Python 3>.

It will be great if you can merge this G2P into Tihu.

[mohamad-hasan-sohan-ajini]

Hey @b00f

I'll be glad if I could participate in the Tihu project. It was the reason I started this repo. Would you please tell me what repo should I look? This is the repo I should contribute to or this one? It's been a long time since the last time I kept in touch with you.

thank in advances

[b00f]

@hajix

Look at this line

Here we use g2p as interactive python app. I think you may change this file to use your library in intractive mode or better if you can make it non-interactive mode. @ebraminio maybe can help us on this matter.

I checked today, you are part of developer team in Tihu, therefor you have write access to all repositories under TihuNLP

[mohamad-hasan-sohan-ajini]

I'll take a look in couple of days.

[b00f]

Please don't hesitate to contact me if you need help.

[mohamad-hasan-sohan-ajini]

Hey b00f

I take a look at the line you mentioned. I think it's easier (and more beneficial) to implement a G2P class in C++, rather than opening PIPE and interact with a an executive process. So I opened this repo for this purpose. I thinks it'll take me about two weeks to complete.

[b00f]

@hajix, you are right. This approach is much better. Soon we can make it. I am so excited about it.

[mohamad-hasan-sohan-ajini]

Hey @b00f

I genuinely believe that CPPG2P is ready to be used in Tihu project. The src/test.cpp contains a quite descriptive example. Please take a look at it and tell me if something is wrong with that.

Regards

[b00f]

@hajix

It looks perfect. I suggest to create a separate test folder next to src.

Right now we can merge the code.